From 0f1a9764b04278994c43afb4482dfafe233eff3c Mon Sep 17 00:00:00 2001 From: Michael Meffie Date: Mon, 13 Dec 2010 14:53:50 -0500 Subject: [PATCH] xstat: print collection values in debug mode Print the values of the integers returned in the collection data when the -debug option is given to xstat_fs_test and xstat_cm_test test programs. This allows us to at least see what the unformatted values are when there is a mismatch in timeval sizes between the host and client (aka the 32/64 bit xstat bug). This change could break scripts which call the xstat test programs with the debug option. New debug output are prepended with 'debug:' to be easily ignored. Reviewed-on: http://gerrit.openafs.org/2878 Reviewed-by: Derrick Brashear Tested-by: BuildBot Reviewed-by: Jeffrey Altman (cherry picked from commit 13aeb1dcaee5ad4e95477464860963788c5d1469) Change-Id: Ief2f9346fad92e86aa2a214f1a462a10560c6e64 Reviewed-on: http://gerrit.openafs.org/9567 Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand Tested-by: BuildBot --- src/xstat/xstat_cm_test.c | 13 +++++++++++++ src/xstat/xstat_fs_test.c | 13 +++++++++++++ 2 files changed, 26 insertions(+) diff --git a/src/xstat/xstat_cm_test.c b/src/xstat/xstat_cm_test.c index 5c1f22344..0573ea75d 100644 --- a/src/xstat/xstat_cm_test.c +++ b/src/xstat/xstat_cm_test.c @@ -1290,6 +1290,19 @@ CM_Handler(void) return (0); } + if (debugging_on) { + int i; + int numInt32s = xstat_cm_Results.data.AFSCB_CollData_len; + afs_int32 *entry = xstat_cm_Results.data.AFSCB_CollData_val; + + printf("debug: got collection number %d\n", xstat_cm_Results.collectionNumber); + printf("debug: collection data length is %d\n", numInt32s); + for (i = 0; i < numInt32s; i++) { + printf("debug: entry %d %u\n", i, entry[i]); + } + printf("\n"); + } + switch (xstat_cm_Results.collectionNumber) { case AFSCB_XSTATSCOLL_CALL_INFO: /* Why was this commented out in 3.3 ? */ diff --git a/src/xstat/xstat_fs_test.c b/src/xstat/xstat_fs_test.c index ba9677b57..63f382c17 100644 --- a/src/xstat/xstat_fs_test.c +++ b/src/xstat/xstat_fs_test.c @@ -537,6 +537,19 @@ FS_Handler(void) return (0); } + if (debugging_on) { + int i; + int numInt32s = xstat_fs_Results.data.AFS_CollData_len; + afs_int32 *entry = xstat_fs_Results.data.AFS_CollData_val; + + printf("debug: got collection number %d\n", xstat_fs_Results.collectionNumber); + printf("debug: collection data length is %d\n", numInt32s); + for (i = 0; i < numInt32s; i++) { + printf("debug: entry %d %u\n", i, entry[i]); + } + printf("\n"); + } + switch (xstat_fs_Results.collectionNumber) { case AFS_XSTATSCOLL_CALL_INFO: PrintCallInfo(); -- 2.39.5