From 10750393dc96b5892e6ae95b95f61e5009a7c2b8 Mon Sep 17 00:00:00 2001 From: Jeffrey Altman Date: Sat, 29 Nov 2003 20:23:24 +0000 Subject: [PATCH] jbuelhler-flexelint-aggregate-initialization-patches-20031129 This patch mainly makes explicit some initializations that were implicit. There are several places where it looks like the missing initialization may be a bug, and I have inserted comments to that effect in the relevant patches. Someone needs to look at them and supply whatever is missing (if anything is). In make_keyperm.c, an array was sized too large. -- Joe Buehler --- src/WINNT/afsapplib/al_cover.cpp | 8 +-- src/WINNT/afssvrcfg/create_partition_dlg.cpp | 20 +++--- src/WINNT/afssvrcfg/salvage_results_dlg.cpp | 8 +-- src/WINNT/afssvrmgr/action.cpp | 6 +- src/WINNT/afssvrmgr/agg_tab.cpp | 8 +-- src/WINNT/afssvrmgr/cmdline.cpp | 18 +++--- src/WINNT/afssvrmgr/columns.cpp | 16 ++--- src/WINNT/afssvrmgr/set_tab.cpp | 14 ++--- src/WINNT/afssvrmgr/svc_tab.cpp | 12 ++-- src/WINNT/afssvrmgr/svc_viewlog.cpp | 14 ++--- src/WINNT/afssvrmgr/svr_salvage.cpp | 8 +-- src/WINNT/afssvrmgr/svr_window.cpp | 8 +-- src/WINNT/afssvrmgr/window.cpp | 66 ++++++++++---------- src/WINNT/afsusrmgr/action.cpp | 6 +- src/WINNT/afsusrmgr/cmdline.cpp | 8 +-- src/WINNT/afsusrmgr/columns.cpp | 6 +- src/WINNT/afsusrmgr/grp_tab.cpp | 20 +++--- src/WINNT/afsusrmgr/mch_tab.cpp | 20 +++--- src/WINNT/afsusrmgr/usr_tab.cpp | 20 +++--- src/WINNT/afsusrmgr/window.cpp | 18 +++--- src/WINNT/client_creds/afswiz.cpp | 12 ++-- src/budb/ol_verify.c | 3 + src/des/make_keyperm.c | 2 +- src/rxkad/rxkad_server.c | 3 + src/vol/vol-salvage.c | 2 +- 25 files changed, 166 insertions(+), 160 deletions(-) diff --git a/src/WINNT/afsapplib/al_cover.cpp b/src/WINNT/afsapplib/al_cover.cpp index b9639bdb7..5a02c71fe 100644 --- a/src/WINNT/afsapplib/al_cover.cpp +++ b/src/WINNT/afsapplib/al_cover.cpp @@ -21,10 +21,10 @@ extern "C" { */ rwWindowData awdCover[] = { - { IDC_COVER_BORDER, raSizeX | raSizeY }, - { IDC_COVER_DESC, raSizeX | raSizeY | raRepaint }, - { IDC_COVER_BUTTON, raMoveX | raMoveY | raRepaint }, - { idENDLIST, 0 } + { IDC_COVER_BORDER, raSizeX | raSizeY, 0, 0 }, + { IDC_COVER_DESC, raSizeX | raSizeY | raRepaint, 0, 0 }, + { IDC_COVER_BUTTON, raMoveX | raMoveY | raRepaint, 0, 0 }, + { idENDLIST, 0, 0, 0 } }; #define WS_EX_HIDDENBYCOVER 0x10000000L diff --git a/src/WINNT/afssvrcfg/create_partition_dlg.cpp b/src/WINNT/afssvrcfg/create_partition_dlg.cpp index b591ea724..93f419bef 100644 --- a/src/WINNT/afssvrcfg/create_partition_dlg.cpp +++ b/src/WINNT/afssvrcfg/create_partition_dlg.cpp @@ -40,16 +40,16 @@ static TCHAR szDrive[4]; static TCHAR szSize[32]; static rwWindowData arwDialog[] = { - { IDC_TITLE, raSizeX | raRepaint }, - { IDC_DRIVE_LIST, raSizeX | raSizeY, MAKELONG(350, 150) }, - { IDC_ARGS_FRAME, raSizeX | raMoveY }, - { IDC_NAME_STATIC, raMoveY | raRepaint }, - { IDC_VICEP_STATIC, raMoveY | raRepaint }, - { IDC_PARTITION_NAME, raMoveY | raRepaint }, - { IDC_CREATE, raMoveX | raMoveY }, - { IDC_CLOSE, raMoveX | raMoveY }, - { 9, raMoveX | raMoveY }, - { idENDLIST, 0 } + { IDC_TITLE, raSizeX | raRepaint, 0, 0 }, + { IDC_DRIVE_LIST, raSizeX | raSizeY, MAKELONG(350, 150), 0 }, + { IDC_ARGS_FRAME, raSizeX | raMoveY, 0, 0 }, + { IDC_NAME_STATIC, raMoveY | raRepaint, 0, 0 }, + { IDC_VICEP_STATIC, raMoveY | raRepaint, 0, 0 }, + { IDC_PARTITION_NAME, raMoveY | raRepaint, 0, 0 }, + { IDC_CREATE, raMoveX | raMoveY, 0, 0 }, + { IDC_CLOSE, raMoveX | raMoveY, 0, 0 }, + { 9, raMoveX | raMoveY, 0, 0 }, + { idENDLIST, 0, 0, 0 } }; diff --git a/src/WINNT/afssvrcfg/salvage_results_dlg.cpp b/src/WINNT/afssvrcfg/salvage_results_dlg.cpp index 615feb525..41e983917 100644 --- a/src/WINNT/afssvrcfg/salvage_results_dlg.cpp +++ b/src/WINNT/afssvrcfg/salvage_results_dlg.cpp @@ -29,10 +29,10 @@ static const int EDIT_CONTROL_MAX_CHARS = 64000; // Max chars an static const char *SALVAGE_LOG_FILE_NAME = "SalvageLog.txt"; static rwWindowData arwDialog[] = { - { IDC_LOG, raSizeX | raSizeY, MAKELONG(350, 150) }, - { IDC_CLOSE, raMoveX | raMoveY }, - { 9, raMoveX | raMoveY }, - { idENDLIST, 0 } + { IDC_LOG, raSizeX | raSizeY, MAKELONG(350, 150), 0 }, + { IDC_CLOSE, raMoveX | raMoveY, 0, 0 }, + { 9, raMoveX | raMoveY, 0, 0 }, + { idENDLIST, 0, 0, 0 } }; diff --git a/src/WINNT/afssvrmgr/action.cpp b/src/WINNT/afssvrmgr/action.cpp index 560818ebd..4f9301721 100644 --- a/src/WINNT/afssvrmgr/action.cpp +++ b/src/WINNT/afssvrmgr/action.cpp @@ -118,9 +118,9 @@ static struct l } l; rwWindowData awdActions[] = { - { IDC_ACTION_DESC, raSizeX | raRepaint }, - { IDC_ACTION_LIST, raSizeX | raSizeY, MAKELONG(cxMIN_ACTION,cyMIN_ACTION) }, - { idENDLIST, 0 } + { IDC_ACTION_DESC, raSizeX | raRepaint, 0, 0 }, + { IDC_ACTION_LIST, raSizeX | raSizeY, MAKELONG(cxMIN_ACTION,cyMIN_ACTION), 0 }, + { idENDLIST, 0, 0, 0 } }; diff --git a/src/WINNT/afssvrmgr/agg_tab.cpp b/src/WINNT/afssvrmgr/agg_tab.cpp index 290709f56..a4ac9150d 100644 --- a/src/WINNT/afssvrmgr/agg_tab.cpp +++ b/src/WINNT/afssvrmgr/agg_tab.cpp @@ -27,10 +27,10 @@ extern "C" { */ rwWindowData awdAggregates[] = { - { IDC_AGG_DESC, raSizeX }, - { IDC_AGG_LIST, raSizeX | raSizeY }, - { IDC_AGG_CREATESET, raMoveX | raMoveY }, - { idENDLIST, 0 } + { IDC_AGG_DESC, raSizeX, 0, 0 }, + { IDC_AGG_LIST, raSizeX | raSizeY, 0, 0 }, + { IDC_AGG_CREATESET, raMoveX | raMoveY, 0, 0 }, + { idENDLIST, 0, 0, 0 } }; diff --git a/src/WINNT/afssvrmgr/cmdline.cpp b/src/WINNT/afssvrmgr/cmdline.cpp index 229302768..8576bc269 100644 --- a/src/WINNT/afssvrmgr/cmdline.cpp +++ b/src/WINNT/afssvrmgr/cmdline.cpp @@ -43,15 +43,15 @@ static struct { BOOL fPresent; TCHAR szValue[ cchRESOURCE ]; } aSWITCHES[] = { - { TEXT("cell"), TRUE }, - { TEXT("subset"), TRUE }, - { TEXT("server"), TRUE }, - { TEXT("reset"), FALSE }, - { TEXT("confirm"), FALSE }, - { TEXT("user"), TRUE }, - { TEXT("password"), TRUE }, - { TEXT("lookup"), FALSE }, - { TEXT("useexisting"), FALSE } + { TEXT("cell"), TRUE, FALSE, TEXT("") }, + { TEXT("subset"), TRUE, FALSE, TEXT("") }, + { TEXT("server"), TRUE, FALSE, TEXT("") }, + { TEXT("reset"), FALSE, FALSE, TEXT("") }, + { TEXT("confirm"), FALSE, FALSE, TEXT("") }, + { TEXT("user"), TRUE, FALSE, TEXT("") }, + { TEXT("password"), TRUE, FALSE, TEXT("") }, + { TEXT("lookup"), FALSE, FALSE, TEXT("") }, + { TEXT("useexisting"), FALSE, FALSE, TEXT("") } }; #define nSWITCHES (sizeof(aSWITCHES) / sizeof(aSWITCHES[0])) diff --git a/src/WINNT/afssvrmgr/columns.cpp b/src/WINNT/afssvrmgr/columns.cpp index 8ae99105c..50a1c4feb 100644 --- a/src/WINNT/afssvrmgr/columns.cpp +++ b/src/WINNT/afssvrmgr/columns.cpp @@ -62,14 +62,14 @@ static struct } COLUMNS[] = { - { IDS_COL_SERVERS, FALSE }, // ceSERVERS - { IDS_COL_FILESETS, FALSE }, // ceFILESETS - { IDS_COL_AGGREGATES, FALSE }, // ceAGGREGATES - { IDS_COL_SERVICES, FALSE }, // ceSERVICES - { IDS_COL_REPLICAS, FALSE }, // ceREPLICAS - { IDS_COL_AGGS_MOVE, TRUE }, // ceAGG_MOVE - { IDS_COL_AGGS_CREATE, TRUE }, // ceAGG_CREATE - { IDS_COL_AGGS_RESTORE, TRUE } // ceAGG_RESTORE + { IDS_COL_SERVERS, FALSE, {0}, FALSE }, // ceSERVERS + { IDS_COL_FILESETS, FALSE, {0}, FALSE }, // ceFILESETS + { IDS_COL_AGGREGATES, FALSE, {0}, FALSE }, // ceAGGREGATES + { IDS_COL_SERVICES, FALSE, {0}, FALSE }, // ceSERVICES + { IDS_COL_REPLICAS, FALSE, {0}, FALSE }, // ceREPLICAS + { IDS_COL_AGGS_MOVE, TRUE, {0}, FALSE }, // ceAGG_MOVE + { IDS_COL_AGGS_CREATE, TRUE, {0}, FALSE }, // ceAGG_CREATE + { IDS_COL_AGGS_RESTORE, TRUE, {0}, FALSE } // ceAGG_RESTORE }; #define nCOLUMNS (sizeof(COLUMNS)/sizeof(COLUMNS[0])) diff --git a/src/WINNT/afssvrmgr/set_tab.cpp b/src/WINNT/afssvrmgr/set_tab.cpp index 7ce28ef8e..9d6cab3cb 100644 --- a/src/WINNT/afssvrmgr/set_tab.cpp +++ b/src/WINNT/afssvrmgr/set_tab.cpp @@ -34,13 +34,13 @@ extern "C" { */ rwWindowData awdFilesets[] = { - { IDC_SET_DESC, raSizeX }, - { IDC_SET_LIST, raSizeX | raSizeY }, - { IDC_SET_CREATE, raMoveX | raMoveY }, - { IDC_SET_DELETE, raMoveX | raMoveY }, - { IDC_SET_REP, raMoveX | raMoveY }, - { IDC_SET_SETQUOTA, raMoveX | raMoveY }, - { idENDLIST, 0 } + { IDC_SET_DESC, raSizeX, 0, 0 }, + { IDC_SET_LIST, raSizeX | raSizeY, 0, 0 }, + { IDC_SET_CREATE, raMoveX | raMoveY, 0, 0 }, + { IDC_SET_DELETE, raMoveX | raMoveY, 0, 0 }, + { IDC_SET_REP, raMoveX | raMoveY, 0, 0 }, + { IDC_SET_SETQUOTA, raMoveX | raMoveY, 0, 0 }, + { idENDLIST, 0, 0, 0 } }; diff --git a/src/WINNT/afssvrmgr/svc_tab.cpp b/src/WINNT/afssvrmgr/svc_tab.cpp index 0227dcc27..4dfc9748a 100644 --- a/src/WINNT/afssvrmgr/svc_tab.cpp +++ b/src/WINNT/afssvrmgr/svc_tab.cpp @@ -26,12 +26,12 @@ extern "C" { */ rwWindowData awdServices[] = { - { IDC_SVC_DESC, raSizeX }, - { IDC_SVC_LIST, raSizeX | raSizeY }, - { IDC_SVC_CREATE, raMoveX | raMoveY }, - { IDC_SVC_DELETE, raMoveX | raMoveY }, - { IDC_SVC_RESTART, raMoveX | raMoveY }, - { idENDLIST, 0 } + { IDC_SVC_DESC, raSizeX, 0, 0 }, + { IDC_SVC_LIST, raSizeX | raSizeY, 0, 0 }, + { IDC_SVC_CREATE, raMoveX | raMoveY, 0, 0 }, + { IDC_SVC_DELETE, raMoveX | raMoveY, 0, 0 }, + { IDC_SVC_RESTART, raMoveX | raMoveY, 0, 0 }, + { idENDLIST, 0, 0, 0 } }; diff --git a/src/WINNT/afssvrmgr/svc_viewlog.cpp b/src/WINNT/afssvrmgr/svc_viewlog.cpp index a73689fed..7cbc57d13 100644 --- a/src/WINNT/afssvrmgr/svc_viewlog.cpp +++ b/src/WINNT/afssvrmgr/svc_viewlog.cpp @@ -30,13 +30,13 @@ extern "C" { */ rwWindowData awdShowLog[] = { - { IDC_SVC_VIEWLOG_DESC, raSizeX | raRepaint }, - { IDC_SVC_VIEWLOG_FILENAME, raSizeX | raRepaint }, - { IDC_VIEWLOG_TEXT, raSizeX | raSizeY | raRepaint, MAKELONG(cxMIN_VIEWLOG,cyMIN_VIEWLOG) }, - { IDC_SVC_VIEWLOG_CONTENTS, raSizeX }, - { IDOK, raMoveX | raMoveY }, - { IDC_VIEWLOG_SAVEAS, raMoveX | raMoveY }, - { idENDLIST, 0 } + { IDC_SVC_VIEWLOG_DESC, raSizeX | raRepaint, 0, 0 }, + { IDC_SVC_VIEWLOG_FILENAME, raSizeX | raRepaint, 0, 0 }, + { IDC_VIEWLOG_TEXT, raSizeX | raSizeY | raRepaint, MAKELONG(cxMIN_VIEWLOG,cyMIN_VIEWLOG), 0 }, + { IDC_SVC_VIEWLOG_CONTENTS, raSizeX, 0, 0 }, + { IDOK, raMoveX | raMoveY, 0, 0 }, + { IDC_VIEWLOG_SAVEAS, raMoveX | raMoveY, 0, 0 }, + { idENDLIST, 0, 0, 0 } }; diff --git a/src/WINNT/afssvrmgr/svr_salvage.cpp b/src/WINNT/afssvrmgr/svr_salvage.cpp index c08ae7a5b..2cc46ba14 100644 --- a/src/WINNT/afssvrmgr/svr_salvage.cpp +++ b/src/WINNT/afssvrmgr/svr_salvage.cpp @@ -32,10 +32,10 @@ extern "C" { */ rwWindowData awdSalvageResults[] = { - { IDC_SALVAGE_TITLE, raSizeX | raRepaint }, - { IDC_SALVAGE_DETAILS, raSizeX | raSizeY | raRepaint, MAKELONG(cxMIN_SALVAGE_R,cyMIN_SALVAGE_R) }, - { IDOK, raMoveX | raMoveY }, - { idENDLIST, 0 } + { IDC_SALVAGE_TITLE, raSizeX | raRepaint, 0, 0 }, + { IDC_SALVAGE_DETAILS, raSizeX | raSizeY | raRepaint, MAKELONG(cxMIN_SALVAGE_R,cyMIN_SALVAGE_R), 0 }, + { IDOK, raMoveX | raMoveY, 0, 0 }, + { idENDLIST, 0, 0, 0 } }; diff --git a/src/WINNT/afssvrmgr/svr_window.cpp b/src/WINNT/afssvrmgr/svr_window.cpp index 0cd18811f..d57f07008 100644 --- a/src/WINNT/afssvrmgr/svr_window.cpp +++ b/src/WINNT/afssvrmgr/svr_window.cpp @@ -31,13 +31,13 @@ extern "C" { #define cyMIN_SERVER 100 static rwWindowData awdServer[] = { - { IDC_TABS, raSizeX | raSizeY, MAKELONG(cxMIN_SERVER,cyMIN_SERVER) }, - { idENDLIST, 0 } + { IDC_TABS, raSizeX | raSizeY, MAKELONG(cxMIN_SERVER,cyMIN_SERVER), 0 }, + { idENDLIST, 0, 0, 0 } }; static rwWindowData awdTabChild[] = { - { 0, raSizeX | raSizeY }, - { idENDLIST, 0 } + { 0, raSizeX | raSizeY, 0, 0 }, + { idENDLIST, 0, 0, 0 } }; diff --git a/src/WINNT/afssvrmgr/window.cpp b/src/WINNT/afssvrmgr/window.cpp index dc129b5b8..473dd50c6 100644 --- a/src/WINNT/afssvrmgr/window.cpp +++ b/src/WINNT/afssvrmgr/window.cpp @@ -47,48 +47,48 @@ extern "C" { #define cyMIN_WINDOW 120 rwWindowData awdMain[] = { - { IDC_CELL_BORDER, raSizeX }, - { IDC_CELL, raSizeX | raRepaint }, - { IDC_AFS_ID, raSizeX | raRepaint }, - { IDC_SERVERS, raSizeX | raSizeY, MAKELONG(cxMIN_SERVER,cyMIN_SERVER) }, - { IDC_COVERDLG, raSizeX | raSizeY }, - { IDC_ANIMATE, raMoveX }, - { idENDLIST, 0 } + { IDC_CELL_BORDER, raSizeX, 0, 0 }, + { IDC_CELL, raSizeX | raRepaint, 0, 0 }, + { IDC_AFS_ID, raSizeX | raRepaint, 0, 0 }, + { IDC_SERVERS, raSizeX | raSizeY, MAKELONG(cxMIN_SERVER,cyMIN_SERVER), 0 }, + { IDC_COVERDLG, raSizeX | raSizeY, 0, 0 }, + { IDC_ANIMATE, raMoveX, 0, 0 }, + { idENDLIST, 0, 0, 0 } }; rwWindowData awdMainVert[] = { - { IDC_CELL_BORDER, raSizeX }, - { IDC_CELL, raSizeX | raRepaint }, - { IDC_AFS_ID, raSizeX | raRepaint }, - { IDC_SERVERS, raSizeX, MAKELONG(cxMIN_SERVER,cyMIN_SERVER) }, - { IDC_SPLITTER_SERVER, raSizeX }, - { IDC_TABS, raSizeX | raSizeY, MAKELONG(cxMIN_TABS,cyMIN_TABS) }, - { IDC_COVERDLG, raSizeX }, - { IDC_ANIMATE, raMoveX }, - { idENDLIST, 0 } + { IDC_CELL_BORDER, raSizeX, 0, 0 }, + { IDC_CELL, raSizeX | raRepaint, 0, 0 }, + { IDC_AFS_ID, raSizeX | raRepaint, 0, 0 }, + { IDC_SERVERS, raSizeX, MAKELONG(cxMIN_SERVER,cyMIN_SERVER), 0 }, + { IDC_SPLITTER_SERVER, raSizeX, 0, 0 }, + { IDC_TABS, raSizeX | raSizeY, MAKELONG(cxMIN_TABS,cyMIN_TABS), 0 }, + { IDC_COVERDLG, raSizeX, 0, 0 }, + { IDC_ANIMATE, raMoveX, 0, 0 }, + { idENDLIST, 0, 0, 0 } }; rwWindowData awdMainHorz[] = { - { IDC_CELL_BORDER, raSizeX }, - { IDC_CELL, raSizeX | raRepaint }, - { IDC_AFS_ID, raSizeX | raRepaint }, - { IDC_SERVERS, raSizeY, MAKELONG(cxMIN_SERVER,cyMIN_SERVER) }, - { IDC_SPLITTER_SERVER, raSizeY }, - { IDC_TABS, raSizeX | raSizeY, MAKELONG(cxMIN_TABS,cyMIN_TABS) }, - { IDC_COVERDLG, raSizeY }, - { IDC_ANIMATE, raMoveX }, - { idENDLIST, 0 } + { IDC_CELL_BORDER, raSizeX, 0, 0 }, + { IDC_CELL, raSizeX | raRepaint, 0, 0 }, + { IDC_AFS_ID, raSizeX | raRepaint, 0, 0 }, + { IDC_SERVERS, raSizeY, MAKELONG(cxMIN_SERVER,cyMIN_SERVER), 0 }, + { IDC_SPLITTER_SERVER, raSizeY, 0, 0 }, + { IDC_TABS, raSizeX | raSizeY, MAKELONG(cxMIN_TABS,cyMIN_TABS), 0 }, + { IDC_COVERDLG, raSizeY, 0, 0 }, + { IDC_ANIMATE, raMoveX, 0, 0 }, + { idENDLIST, 0, 0, 0 } }; rwWindowData awdSplitServer[] = { - { IDC_CELL, raRepaint }, - { IDC_AFS_ID, raRepaint }, - { IDC_SERVERS, raSizeX | raSizeY, MAKELONG(cxMIN_SERVER,cyMIN_SERVER) }, - { IDC_SPLITTER_SERVER, raMoveX | raMoveY }, - { IDC_TABS, raMoveX | raMoveY | raSizeXB | raSizeYB, MAKELONG(cxMIN_TABS,cyMIN_TABS) }, - { IDC_COVERDLG, raSizeX | raSizeY }, - { IDC_ANIMATE, 0 }, - { idENDLIST, 0 } + { IDC_CELL, raRepaint, 0, 0 }, + { IDC_AFS_ID, raRepaint, 0, 0 }, + { IDC_SERVERS, raSizeX | raSizeY, MAKELONG(cxMIN_SERVER,cyMIN_SERVER), 0 }, + { IDC_SPLITTER_SERVER, raMoveX | raMoveY, 0, 0 }, + { IDC_TABS, raMoveX | raMoveY | raSizeXB | raSizeYB, MAKELONG(cxMIN_TABS,cyMIN_TABS), 0 }, + { IDC_COVERDLG, raSizeX | raSizeY, 0, 0 }, + { IDC_ANIMATE, 0, 0, 0 }, + { idENDLIST, 0, 0, 0 } }; diff --git a/src/WINNT/afsusrmgr/action.cpp b/src/WINNT/afsusrmgr/action.cpp index 48d48970b..22bfb76b7 100644 --- a/src/WINNT/afsusrmgr/action.cpp +++ b/src/WINNT/afsusrmgr/action.cpp @@ -59,9 +59,9 @@ static struct } l; rwWindowData awdActions[] = { - { IDC_ACTION_DESC, raSizeX | raRepaint }, - { IDC_ACTION_LIST, raSizeX | raSizeY, MAKELONG(cxMIN_ACTION,cyMIN_ACTION) }, - { idENDLIST, 0 } + { IDC_ACTION_DESC, raSizeX | raRepaint, 0, 0 }, + { IDC_ACTION_LIST, raSizeX | raSizeY, MAKELONG(cxMIN_ACTION,cyMIN_ACTION), 0 }, + { idENDLIST, 0, 0, 0 } }; diff --git a/src/WINNT/afsusrmgr/cmdline.cpp b/src/WINNT/afsusrmgr/cmdline.cpp index cd3d950d0..36abdb6e4 100644 --- a/src/WINNT/afsusrmgr/cmdline.cpp +++ b/src/WINNT/afsusrmgr/cmdline.cpp @@ -38,10 +38,10 @@ static struct { BOOL fPresent; TCHAR szValue[ cchRESOURCE ]; } aSWITCHES[] = { - { TEXT("cell"), TRUE }, - { TEXT("remote"), TRUE }, - { TEXT("user"), TRUE }, - { TEXT("password"), TRUE } + { TEXT("cell"), TRUE, FALSE, TEXT("") }, + { TEXT("remote"), TRUE, FALSE, TEXT("") }, + { TEXT("user"), TRUE, FALSE, TEXT("") }, + { TEXT("password"), TRUE, FALSE, TEXT("") } }; #define nSWITCHES (sizeof(aSWITCHES) / sizeof(aSWITCHES[0])) diff --git a/src/WINNT/afsusrmgr/columns.cpp b/src/WINNT/afsusrmgr/columns.cpp index fb3e8fef6..16eeefea3 100644 --- a/src/WINNT/afsusrmgr/columns.cpp +++ b/src/WINNT/afsusrmgr/columns.cpp @@ -55,9 +55,9 @@ static struct } COLUMNS[] = { - { IDS_COL_USERS, FALSE }, // ceUSERS - { IDS_COL_GROUPS, FALSE }, // ceGROUPS - { IDS_COL_MACHINES, FALSE }, // ceMACHINES + { IDS_COL_USERS, FALSE, {0}, FALSE }, // ceUSERS + { IDS_COL_GROUPS, FALSE, {0}, FALSE }, // ceGROUPS + { IDS_COL_MACHINES, FALSE, {0}, FALSE }, // ceMACHINES }; #define nCOLUMNS (sizeof(COLUMNS)/sizeof(COLUMNS[0])) diff --git a/src/WINNT/afsusrmgr/grp_tab.cpp b/src/WINNT/afsusrmgr/grp_tab.cpp index 8c503da52..024f234ce 100644 --- a/src/WINNT/afsusrmgr/grp_tab.cpp +++ b/src/WINNT/afsusrmgr/grp_tab.cpp @@ -25,16 +25,16 @@ extern "C" { */ rwWindowData awdGroupsTab[] = { - { IDC_GROUPS_TITLE, raRepaint | raSizeX }, - { IDC_ADVANCED, raMoveX }, - { IDC_GROUPS_PATTERN, raMoveX }, - { IDC_GROUPS_PATTERN_PROMPT, raRepaint | raMoveX }, - { IDC_GROUPS_LIST, raSizeX | raSizeY }, - { M_GROUP_CREATE, raMoveX | raMoveY }, - { M_MEMBERSHIP, raMoveX | raMoveY }, - { M_PROPERTIES, raMoveX | raMoveY }, - { IDC_STATIC, raRepaint }, - { idENDLIST, 0 } + { IDC_GROUPS_TITLE, raRepaint | raSizeX, 0, 0 }, + { IDC_ADVANCED, raMoveX, 0, 0 }, + { IDC_GROUPS_PATTERN, raMoveX, 0, 0 }, + { IDC_GROUPS_PATTERN_PROMPT, raRepaint | raMoveX, 0, 0 }, + { IDC_GROUPS_LIST, raSizeX | raSizeY, 0, 0 }, + { M_GROUP_CREATE, raMoveX | raMoveY, 0, 0 }, + { M_MEMBERSHIP, raMoveX | raMoveY, 0, 0 }, + { M_PROPERTIES, raMoveX | raMoveY, 0, 0 }, + { IDC_STATIC, raRepaint, 0, 0 }, + { idENDLIST, 0, 0, 0 } }; diff --git a/src/WINNT/afsusrmgr/mch_tab.cpp b/src/WINNT/afsusrmgr/mch_tab.cpp index ba031e291..116117a03 100644 --- a/src/WINNT/afsusrmgr/mch_tab.cpp +++ b/src/WINNT/afsusrmgr/mch_tab.cpp @@ -25,16 +25,16 @@ extern "C" { */ rwWindowData awdMachinesTab[] = { - { IDC_MACHINES_TITLE, raRepaint | raSizeX }, - { IDC_ADVANCED, raMoveX }, - { IDC_MACHINES_PATTERN, raMoveX }, - { IDC_MACHINES_PATTERN_PROMPT, raRepaint | raMoveX }, - { IDC_MACHINES_LIST, raSizeX | raSizeY }, - { M_MACHINE_CREATE, raMoveX | raMoveY }, - { M_MEMBERSHIP, raMoveX | raMoveY }, - { M_PROPERTIES, raMoveX | raMoveY }, - { IDC_STATIC, raRepaint }, - { idENDLIST, 0 } + { IDC_MACHINES_TITLE, raRepaint | raSizeX, 0, 0 }, + { IDC_ADVANCED, raMoveX, 0, 0 }, + { IDC_MACHINES_PATTERN, raMoveX, 0, 0 }, + { IDC_MACHINES_PATTERN_PROMPT, raRepaint | raMoveX, 0, 0 }, + { IDC_MACHINES_LIST, raSizeX | raSizeY, 0, 0 }, + { M_MACHINE_CREATE, raMoveX | raMoveY, 0, 0 }, + { M_MEMBERSHIP, raMoveX | raMoveY, 0, 0 }, + { M_PROPERTIES, raMoveX | raMoveY, 0, 0 }, + { IDC_STATIC, raRepaint, 0, 0 }, + { idENDLIST, 0, 0, 0 } }; diff --git a/src/WINNT/afsusrmgr/usr_tab.cpp b/src/WINNT/afsusrmgr/usr_tab.cpp index fde6316ad..d8541bd3d 100644 --- a/src/WINNT/afsusrmgr/usr_tab.cpp +++ b/src/WINNT/afsusrmgr/usr_tab.cpp @@ -26,16 +26,16 @@ extern "C" { */ rwWindowData awdUsersTab[] = { - { IDC_USERS_TITLE, raRepaint | raSizeX }, - { IDC_ADVANCED, raMoveX }, - { IDC_USERS_PATTERN, raMoveX }, - { IDC_USERS_PATTERN_PROMPT, raRepaint | raMoveX }, - { IDC_USERS_LIST, raSizeX | raSizeY }, - { M_USER_CREATE, raMoveX | raMoveY }, - { M_MEMBERSHIP, raMoveX | raMoveY }, - { M_PROPERTIES, raMoveX | raMoveY }, - { IDC_STATIC, raRepaint }, - { idENDLIST, 0 } + { IDC_USERS_TITLE, raRepaint | raSizeX, 0, 0 }, + { IDC_ADVANCED, raMoveX, 0, 0 }, + { IDC_USERS_PATTERN, raMoveX, 0, 0 }, + { IDC_USERS_PATTERN_PROMPT, raRepaint | raMoveX, 0, 0 }, + { IDC_USERS_LIST, raSizeX | raSizeY, 0, 0 }, + { M_USER_CREATE, raMoveX | raMoveY, 0, 0 }, + { M_MEMBERSHIP, raMoveX | raMoveY, 0, 0 }, + { M_PROPERTIES, raMoveX | raMoveY, 0, 0 }, + { IDC_STATIC, raRepaint, 0, 0 }, + { idENDLIST, 0, 0, 0 } }; diff --git a/src/WINNT/afsusrmgr/window.cpp b/src/WINNT/afsusrmgr/window.cpp index db5638493..f6e6f8d8e 100644 --- a/src/WINNT/afsusrmgr/window.cpp +++ b/src/WINNT/afsusrmgr/window.cpp @@ -52,18 +52,18 @@ static size_t cTABS = sizeof(aTABS) / sizeof(aTABS[0]); #define cyMIN_TABS 100 rwWindowData awdMain[] = { - { IDC_TAB, raSizeX | raSizeY, MAKELONG(cxMIN_TABS,cyMIN_TABS) }, - { IDC_CELL, raSizeX | raRepaint }, - { IDC_CREDS, raSizeX | raRepaint }, - { IDC_ANIM, raMoveX }, - { IDC_BAR, raSizeX }, - { IDC_STATIC, raRepaint }, - { idENDLIST, 0 } + { IDC_TAB, raSizeX | raSizeY, MAKELONG(cxMIN_TABS,cyMIN_TABS), 0 }, + { IDC_CELL, raSizeX | raRepaint, 0, 0 }, + { IDC_CREDS, raSizeX | raRepaint, 0, 0 }, + { IDC_ANIM, raMoveX, 0, 0 }, + { IDC_BAR, raSizeX, 0, 0 }, + { IDC_STATIC, raRepaint, 0, 0 }, + { idENDLIST, 0, 0, 0 } }; rwWindowData awdTabChild[] = { - { 0, raSizeX | raSizeY }, - { idENDLIST, 0 } + { 0, raSizeX | raSizeY, 0, 0 }, + { idENDLIST, 0, 0, 0 } }; diff --git a/src/WINNT/client_creds/afswiz.cpp b/src/WINNT/client_creds/afswiz.cpp index fa67b5e0b..65b942c0c 100644 --- a/src/WINNT/client_creds/afswiz.cpp +++ b/src/WINNT/client_creds/afswiz.cpp @@ -75,12 +75,12 @@ typedef enum } WIZSTEP; static WIZARD_STATE aStates[] = { - { STEP_START, IDD_WIZ_START, WizStart_DlgProc }, - { STEP_STARTING, IDD_WIZ_STARTING, WizStarting_DlgProc }, - { STEP_CREDS, IDD_WIZ_CREDS, WizCreds_DlgProc }, - { STEP_MOUNT, IDD_WIZ_MOUNT, WizMount_DlgProc }, - { STEP_MOUNTING, IDD_WIZ_MOUNTING, WizMounting_DlgProc }, - { STEP_FINISH, IDD_WIZ_FINISH, WizFinish_DlgProc }, + { STEP_START, IDD_WIZ_START, WizStart_DlgProc, 0 }, + { STEP_STARTING, IDD_WIZ_STARTING, WizStarting_DlgProc, 0 }, + { STEP_CREDS, IDD_WIZ_CREDS, WizCreds_DlgProc, 0 }, + { STEP_MOUNT, IDD_WIZ_MOUNT, WizMount_DlgProc, 0 }, + { STEP_MOUNTING, IDD_WIZ_MOUNTING, WizMounting_DlgProc, 0 }, + { STEP_FINISH, IDD_WIZ_FINISH, WizFinish_DlgProc, 0 } }; static const int cStates = sizeof(aStates) / sizeof(aStates[0]); diff --git a/src/budb/ol_verify.c b/src/budb/ol_verify.c index 9787c3d67..2b078e5a8 100644 --- a/src/budb/ol_verify.c +++ b/src/budb/ol_verify.c @@ -148,6 +148,7 @@ int blockEntrySize[NBLOCKTYPES] = { sizeof(((struct tBlock *) NULL)->a[0]), sizeof(((struct dBlock *) NULL)->a[0]), 0 + /* FIXME: possible missing initializer here */ }; char *typeName[NBLOCKTYPES] = { @@ -157,6 +158,7 @@ char *typeName[NBLOCKTYPES] = { "tape", "dump", "hashTable" + /* FIXME: possible missing initializer here */ }; int hashBlockType[HT_MAX_FUNCTION + 1] = { @@ -165,6 +167,7 @@ int hashBlockType[HT_MAX_FUNCTION + 1] = { dump_BLOCK, tape_BLOCK, volInfo_BLOCK + /* FIXME: possible missing initializer here */ }; /* Compatibility table for the bits in the blockMap. */ diff --git a/src/des/make_keyperm.c b/src/des/make_keyperm.c index f34be75b5..e8fdb9cb3 100644 --- a/src/des/make_keyperm.c +++ b/src/des/make_keyperm.c @@ -48,7 +48,7 @@ static int const shift[16 + 1] = { 0, 1, 1, 2, 2, 2, 2, 2, 2, 1, 2, 2, 2, 2, 2, 2, 1, }; -static int const pc_1[64 + 1] = { 0, +static int const pc_1[56 + 1] = { 0, 57, 49, 41, 33, 25, 17, 9, 1, 58, 50, 42, 34, 26, 18, diff --git a/src/rxkad/rxkad_server.c b/src/rxkad/rxkad_server.c index b09f9f698..6a4c32b56 100644 --- a/src/rxkad/rxkad_server.c +++ b/src/rxkad/rxkad_server.c @@ -59,6 +59,9 @@ static struct rx_securityOps rxkad_server_ops = { rxkad_CheckPacket, /* check data packet */ rxkad_DestroyConnection, rxkad_GetStats, + 0, /* spare 1 */ + 0, /* spare 2 */ + 0, /* spare 3 */ }; extern afs_uint32 rx_MyMaxSendSize; diff --git a/src/vol/vol-salvage.c b/src/vol/vol-salvage.c index 2f46a07bc..1d2415202 100644 --- a/src/vol/vol-salvage.c +++ b/src/vol/vol-salvage.c @@ -397,7 +397,7 @@ typedef struct { } childJob_t; /* Child job this process is running. */ -childJob_t myjob = { SALVAGER_MAGIC, NOT_CHILD }; +childJob_t myjob = { SALVAGER_MAGIC, NOT_CHILD, "" }; int nt_SalvagePartition(char *partName, int jobn); int nt_SetupPartitionSalvage(void *datap, int len); -- 2.39.5