From 10a02e70c38c5ccb23f95f0990643230b9709ca5 Mon Sep 17 00:00:00 2001 From: Simon Wilkinson Date: Fri, 30 Mar 2012 19:23:24 +0100 Subject: [PATCH] pam: Don't check if unsigned is < 0 uid_t is unsigned, so checking to see if it is less than 0 is a bit redundant. Remove the checks to silence a warning from clang. Change-Id: I5ae429247d328b3320063b4c035f6e5bb101620b Reviewed-on: http://gerrit.openafs.org/7079 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear --- src/pam/afs_auth.c | 2 +- src/pam/afs_setcred.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/pam/afs_auth.c b/src/pam/afs_auth.c index b4c220f6f..cdeeb0e4f 100644 --- a/src/pam/afs_auth.c +++ b/src/pam/afs_auth.c @@ -102,7 +102,7 @@ pam_sm_authenticate(pam_handle_t * pamh, int flags, int argc, } else { ignore_uid = 1; ignore_uid_id = (uid_t) strtol(argv[i], (char **)NULL, 10); - if ((ignore_uid_id < 0) || (ignore_uid_id > IGNORE_MAX)) { + if (ignore_uid_id > IGNORE_MAX) { ignore_uid = 0; pam_afs_syslog(LOG_ERR, PAMAFS_IGNOREUID, argv[i]); } diff --git a/src/pam/afs_setcred.c b/src/pam/afs_setcred.c index f3d2cb8c9..e52d988ec 100644 --- a/src/pam/afs_setcred.c +++ b/src/pam/afs_setcred.c @@ -92,7 +92,7 @@ pam_sm_setcred(pam_handle_t * pamh, int flags, int argc, const char **argv) } else { ignore_uid = 1; ignore_uid_id = (uid_t) strtol(argv[i], (char **)NULL, 10); - if ((0 > ignore_uid_id) || (ignore_uid_id > IGNORE_MAX)) { + if (ignore_uid_id > IGNORE_MAX) { ignore_uid = 0; pam_afs_syslog(LOG_ERR, PAMAFS_IGNOREUID, argv[i]); } -- 2.39.5