From 1c8b1964f8d24fb709baf04fe2e1460d08fba848 Mon Sep 17 00:00:00 2001 From: Andrew Deason Date: Mon, 31 Jan 2011 15:00:09 -0600 Subject: [PATCH] Rx: Do not stop keepalives on ACKALL receipt We need to still keep sending periodic keepalives after receiving an ACKALL, since the call is not done yet. ACKALLs can be received when the peer has received all data from us, well before the call has finished. This is particularly noticeable for long-lived calls that have little data transfer, such as AFSVolForward and AFSVolForwardMultiple. This reverts commit b1549f29a9515de09d4a64bfb28bf5afdfee2615, which was intended to be part of a fix for RT 20727. FIXES 128848 Reviewed-on: http://gerrit.openafs.org/3876 Tested-by: Andrew Deason Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit ba51b43e3558058b949ccc5de1d4559e4caf9d9b) Change-Id: I9a2edb819ba052786ec9f4c9d15d11ea48905af3 Reviewed-on: http://gerrit.openafs.org/3878 Tested-by: BuildBot Reviewed-by: Derrick Brashear --- src/rx/rx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/rx/rx.c b/src/rx/rx.c index 35d0c7f42..9b404a109 100644 --- a/src/rx/rx.c +++ b/src/rx/rx.c @@ -3424,7 +3424,6 @@ rxi_ReceivePacket(struct rx_packet *np, osi_socket socket, } #endif /* AFS_GLOBAL_RXLOCK_KERNEL */ rxi_ClearTransmitQueue(call, 0); - rxevent_Cancel(call->keepAliveEvent, call, RX_CALL_REFCOUNT_ALIVE); break; default: /* Should not reach here, unless the peer is broken: send an abort -- 2.39.5