From 2373547a86c12f72261072971b8d47e6b7cdd4e6 Mon Sep 17 00:00:00 2001 From: Simon Wilkinson Date: Wed, 23 Nov 2011 16:30:55 +0000 Subject: [PATCH] Unix CM: Fix PutVolume in afs_BlackListOnce It isn't safe to keep accessing a structure once we have Put our reference to it. Change-Id: I6f23a054c3ccde21aa17e07d06dd3c6e7761c098 Reviewed-on: http://gerrit.openafs.org/6117 Tested-by: BuildBot Reviewed-by: Jeffrey Altman --- src/afs/afs_analyze.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/afs/afs_analyze.c b/src/afs/afs_analyze.c index a59b4167d..6bec02dd6 100644 --- a/src/afs/afs_analyze.c +++ b/src/afs/afs_analyze.c @@ -258,13 +258,13 @@ afs_BlackListOnce(struct vrequest *areq, struct VenusFid *afid, areq->skipserver[i] = 1; } } - afs_PutVolume(tvp, READ_LOCK); for (i = 0; i < AFS_MAXHOSTS; i++) { if (tvp->serverHost[i] && areq->skipserver[i] == 0) { serversleft = 1; break; } } + afs_PutVolume(tvp, READ_LOCK); return serversleft; } } -- 2.39.5