From 2e8317d2018e89418abbe541e3ac9c5e5bb524c8 Mon Sep 17 00:00:00 2001 From: Andrew Deason Date: Wed, 14 Dec 2011 14:16:16 -0600 Subject: [PATCH] viced: Yell when we GetSomeSpace_r A GetSomeSpace_r call indicates we don't have enough callbacks configured. For many people, this can happen without the administrator realizing anything is wrong, since we never give any indication that something is amiss, unless the administrator checks the xstat statistics. Since this can indicate a serious performance problem, yell in the log when this happens. Only do it once, so we don't spam the log. Reviewed-on: http://gerrit.openafs.org/6334 Reviewed-by: Michael Meffie Tested-by: BuildBot Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear (cherry picked from commit da3f8d86dd216a90bc400367b7b95e9a427f99e8) Change-Id: I63ec14c6f635c57249023e0fc34b15838cee2eb3 Reviewed-on: http://gerrit.openafs.org/9386 Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand --- src/viced/callback.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/src/viced/callback.c b/src/viced/callback.c index e32c9068a..5566c8105 100644 --- a/src/viced/callback.c +++ b/src/viced/callback.c @@ -1508,6 +1508,19 @@ GetSomeSpace_r(struct host *hostp, int locked) struct lih_params params; int i = 0; + if (cbstuff.GotSomeSpaces == 0) { + /* only log this once; if GSS is getting called constantly, that's not + * good but don't make things worse by spamming the log. */ + ViceLog(0, ("We have run out of callback space; forcing callback revocation. " + "This suggests the fileserver is configured with insufficient " + "callbacks; you probably want to increase the -cb fileserver " + "parameter (current setting: %u). The fileserver will continue " + "to operate, but this may indicate a severe performance problem\n", + cbstuff.nblks)); + ViceLog(0, ("This message is logged at most once; for more information " + "see the OpenAFS documentation and fileserver xstat collection 3\n")); + } + cbstuff.GotSomeSpaces++; ViceLog(5, ("GSS: First looking for timed out call backs via CleanupCallBacks\n")); -- 2.39.5