From 3064879c8d69ca9541c622e9f3f90e7c1e35c26c Mon Sep 17 00:00:00 2001 From: Simon Wilkinson Date: Fri, 16 Oct 2009 22:45:50 +0100 Subject: [PATCH] Update warning management This change tidies up after the recent slew of warning reduction. It updates README.WARNINGS to reflect the current state of the tree, disables warnings for a couple of files that are now warning clean, and ensures that the libuafs and libafsrpc Makefiles match the state of the rest of the tree in terms of which warnings are enabled. Reviewed-on: http://gerrit.openafs.org/672 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear --- README.WARNINGS | 3 +-- src/fsprobe/Makefile.in | 1 - src/kauth/Makefile.in | 1 - src/libafsrpc/Makefile.in | 2 +- src/libuafs/Makefile.common.in | 6 +++--- src/tviced/Makefile.in | 2 +- src/volser/vsprocs.c | 4 ---- 7 files changed, 6 insertions(+), 13 deletions(-) diff --git a/README.WARNINGS b/README.WARNINGS index 79a9c43ff..c954710ea 100644 --- a/README.WARNINGS +++ b/README.WARNINGS @@ -72,7 +72,6 @@ libadmin/bos/afs_bosAdmin.c: all : DES keys, time types, and const libadmin/kas/afs_kasAdmin.c: all : Ubik_Call nonsense, DES keys libadmin/samples/rxstat_query_peer.c : all : util_RPCStatsStateGet types libadmin/samples/rxstat_query_process.c : all : util_RPCStatsStateGet types -libadmin/samples/rxdebug_peers.c : format : struct clock vs unsigned int libadmin/test/client.c : all : util_RPCStatsStateGet types ptserver/ptserver.c : all : ExtendedCellInfo rxkad/rxkad_server.c : all : Des key nonsense @@ -88,10 +87,10 @@ ubik/ubikclient.c : strict-protos : ubik_Call uss/uss_vol.c : all Format issues uss/uss_kauth.c : all : Des keys, ubik_Call uss/lex.yy.c : all : Unused symbols +viced/afsfileprocs.c : all (tviced) : implicit definiton of hpr_* viced/fsprobe.c : all : ubik_Call vlserver/vlserver.c : all : GetExtendedCellInfo vol/salvager.c : all : consts & undefined variable from header volser/vos.c : all : ubik_Call_New volser/vol-dump.c : format : afs_sfsize_t -volser/vsprocs.c : format-extra : The ONERROR macro needs to be rethought diff --git a/src/fsprobe/Makefile.in b/src/fsprobe/Makefile.in index 0550f5c3b..c9e6bd4c9 100644 --- a/src/fsprobe/Makefile.in +++ b/src/fsprobe/Makefile.in @@ -46,7 +46,6 @@ libfsprobe.a: fsprobe.o fsprobe_callback.o AFS_component_version_number.o $(RANLIB) $@ fsprobe.o: fsprobe.c ${INCLS} AFS_component_version_number.c - $(CC) $(CFLAGS) @CFLAGS_NOERROR@ -c $< fsprobe_callback.o: fsprobe_callback.c ${INCLS} diff --git a/src/kauth/Makefile.in b/src/kauth/Makefile.in index 7b81fba9c..c408f47c8 100644 --- a/src/kauth/Makefile.in +++ b/src/kauth/Makefile.in @@ -101,7 +101,6 @@ kaprocs.o: kaprocs.c ${INCLS} kaport.h ${CC} ${CFLAGS} @CFLAGS_NOERROR@ -c $< authclient.o: authclient.c ${INCLS} - $(CC) $(CFLAGS) @CFLAGS_NOERROR@ -c $< kaauxdb.o: kaauxdb.c $(CC) $(CFLAGS) @CFLAGS_NOERROR@ -c $< diff --git a/src/libafsrpc/Makefile.in b/src/libafsrpc/Makefile.in index 50c8aa1b6..6796a6665 100644 --- a/src/libafsrpc/Makefile.in +++ b/src/libafsrpc/Makefile.in @@ -199,7 +199,7 @@ rxkad_common.o: ${RXKAD}/rxkad_common.c ${CCRULE} ${RXKAD}/rxkad_common.c ticket.o: ${RXKAD}/ticket.c - ${CCRULE} @CFLAGS_NOERROR@ ${RXKAD}/ticket.c + ${CCRULE} ${RXKAD}/ticket.c ticket5.o: ${RXKAD}/ticket5.c ${CCRULE} @CFLAGS_NOERROR@ ${RXKAD}/ticket5.c diff --git a/src/libuafs/Makefile.common.in b/src/libuafs/Makefile.common.in index d6f777d12..30d52d447 100644 --- a/src/libuafs/Makefile.common.in +++ b/src/libuafs/Makefile.common.in @@ -788,7 +788,7 @@ $(UOBJ)/osi_vfsops.o: $(TOP_SRC_AFS)/UKERNEL/osi_vfsops.c $(UOBJ)/ktc.o: $(TOP_SRCDIR)/auth/ktc.c $(CRULE1) @CFLAGS_NOERROR@ $(UOBJ)/ticket.o: $(TOP_SRCDIR)/rxkad/ticket.c - $(CRULE1) @CFLAGS_NOERROR@ + $(CRULE1) $(UOBJ)/rxkad_server.o: $(TOP_SRCDIR)/rxkad/rxkad_server.c $(CRULE1) $(UOBJ)/ptint.cs.o: $(TOP_OBJDIR)/src/ptserver/ptint.cs.c @@ -1056,7 +1056,7 @@ $(WEBOBJ)/securehash.o: $(TOP_SRCDIR)/afsweb/securehash.c $(WEBOBJ)/nsafs.o: $(TOP_SRCDIR)/afsweb/nsafs.c $(CRULE2) $(WEBOBJ)/ticket.o: $(TOP_SRCDIR)/rxkad/ticket.c - $(CRULE2) @CFLAGS_NOERROR@ + $(CRULE2) $(WEBOBJ)/rxkad_server.o: $(TOP_SRCDIR)/rxkad/rxkad_server.c $(CRULE2) $(WEBOBJ)/ptint.cs.o: $(TOP_OBJDIR)/src/ptserver/ptint.cs.c @@ -1318,7 +1318,7 @@ $(JUAFS)/osi_vfsops.o: $(TOP_SRC_AFS)/UKERNEL/osi_vfsops.c $(JUAFS)/ktc.o: $(TOP_SRCDIR)/auth/ktc.c $(CRULE1) @CFLAGS_NOERROR@ $(JUAFS)/ticket.o: $(TOP_SRCDIR)/rxkad/ticket.c - $(CRULE1) @CFLAGS_NOERROR@ + $(CRULE1) $(JUAFS)/rxkad_server.o: $(TOP_SRCDIR)/rxkad/rxkad_server.c $(CRULE1) $(JUAFS)/ptint.cs.o: $(TOP_OBJDIR)/src/ptserver/ptint.cs.c diff --git a/src/tviced/Makefile.in b/src/tviced/Makefile.in index 4c01394e4..946415a20 100644 --- a/src/tviced/Makefile.in +++ b/src/tviced/Makefile.in @@ -68,7 +68,7 @@ afsfileprocs.o: ${VICED}/afsfileprocs.c ${CCRULE} @CFLAGS_NOERROR@ host.o: ${VICED}/host.c - ${CCRULE} @CFLAGS_NOERROR@ + ${CCRULE} physio.o: ${VICED}/physio.c ${CCRULE} diff --git a/src/volser/vsprocs.c b/src/volser/vsprocs.c index 678effec1..8adbceb0a 100644 --- a/src/volser/vsprocs.c +++ b/src/volser/vsprocs.c @@ -10,10 +10,6 @@ #include #include -#ifdef IGNORE_SOME_GCC_WARNINGS -# pragma GCC diagnostic warning "-Wformat-extra-args" -#endif - #include #include #include -- 2.39.5