From 333d836050361ae3a7423da9e270784db378bdf0 Mon Sep 17 00:00:00 2001 From: Jeffrey Altman Date: Thu, 29 Jul 2004 17:55:01 +0000 Subject: [PATCH] aklog-20040729 Fix afs_realm_of_cell5() to validate the return value of krb5_get_host_realm --- src/WINNT/aklog/aklog.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/WINNT/aklog/aklog.c b/src/WINNT/aklog/aklog.c index f3a6fb435..35f60d317 100644 --- a/src/WINNT/aklog/aklog.c +++ b/src/WINNT/aklog/aklog.c @@ -355,7 +355,7 @@ static char *afs_realm_of_cell(struct afsconf_cell *cellconfig) static char *afs_realm_of_cell5(krb5_context context, struct afsconf_cell *cellconfig) { - char ** krbrlms; + char ** krbrlms = 0; static char krbrlm[REALM_SZ+1]; krb5_error_code status; @@ -364,14 +364,14 @@ static char *afs_realm_of_cell5(krb5_context context, struct afsconf_cell *cellc status = krb5_get_host_realm( context, cellconfig->hostName[0], &krbrlms ); - if(krbrlms && krbrlms[0]) + if (status == 0 && krbrlms && krbrlms[0]) { strcpy(krbrlm, krbrlms[0]); - else { + } else { strcpy(krbrlm, cellconfig->name); strupr(krbrlm); } - if(krbrlms) + if (krbrlms) krb5_free_host_realm( context, krbrlms ); return krbrlm; -- 2.39.5