From 35108215d98ef78c9bf54cb66597c53f3d03164f Mon Sep 17 00:00:00 2001 From: Simon Wilkinson Date: Fri, 15 Feb 2013 22:34:36 +0000 Subject: [PATCH] libadmin: Don't try to release garbage connection In bos_ServerOpen, initalise the contents of bos_server structure to 0 using calloc, so that if we jump to the error handling stuff before they are assigned real values we don't end up trying to release garbage. Reviewed-on: http://gerrit.openafs.org/9163 Tested-by: BuildBot Reviewed-by: Chas Williams - CONTRACTOR Reviewed-by: Derrick Brashear (cherry picked from commit 17154a3c0afa88f7bb25e2b642fc13ee69c2b7db) Change-Id: Iaa6e5166cb29799feb82ca29ef3e78ceea82d6e2 Reviewed-on: http://gerrit.openafs.org/9524 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand --- src/libadmin/bos/afs_bosAdmin.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libadmin/bos/afs_bosAdmin.c b/src/libadmin/bos/afs_bosAdmin.c index 016145a2d..22ed13e06 100644 --- a/src/libadmin/bos/afs_bosAdmin.c +++ b/src/libadmin/bos/afs_bosAdmin.c @@ -170,7 +170,7 @@ bos_ServerOpen(const void *cellHandle, const char *serverName, int rc = 0; afs_status_t tst = 0; afs_cell_handle_p c_handle = (afs_cell_handle_p) cellHandle; - bos_server_p bos_server = (bos_server_p) malloc(sizeof(bos_server_t)); + bos_server_p bos_server = (bos_server_p) calloc(1, sizeof(bos_server_t)); int serverAddress; /* -- 2.39.5