From 3ce1880c08663e07e0b2817c83c011ca7c250bf2 Mon Sep 17 00:00:00 2001 From: Benjamin Kaduk Date: Wed, 17 Sep 2014 12:07:02 -0400 Subject: [PATCH] Fix disk name initialization in scout Scout needs to initialize names in scout_disk structures to prevent the use of uninitialized data. However, '\0' is a NUL character constant, i.e., the integer value 0, which is interpreted as NULL (the pointer constant) in a pointer context, such as when assigned to a variable of type char*. Since the name field in these structs is passed to printing routines, the safe initialization value is the empty string constant "", not a zero value. Reviewed-on: http://gerrit.openafs.org/11469 Tested-by: BuildBot Reviewed-by: Chas Williams - CONTRACTOR Reviewed-by: Perry Ruiter Reviewed-by: Jeffrey Altman (cherry picked from commit 57ca77786eb6c04519f9358f1456fdf5b8006757) Change-Id: I970e19c698cc26255cd244671908a631ef959c30 Reviewed-on: http://gerrit.openafs.org/12078 Tested-by: BuildBot Reviewed-by: Benjamin Kaduk Reviewed-by: Michael Meffie Reviewed-by: Mark Vitale Reviewed-by: Stephan Wiesand --- src/scout/scout.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/scout/scout.c b/src/scout/scout.c index 2c2b392bf..f087cbdbe 100644 --- a/src/scout/scout.c +++ b/src/scout/scout.c @@ -407,7 +407,7 @@ scout_initDiskLightObjects(struct mini_line *a_line, struct gwin *a_win) curr_disk->prev = i - 1; curr_disk->next = i + 1; curr_disk->active = 0; - curr_disk->name = '\0'; + curr_disk->name = ""; /* * Bump up to the next disk structure. -- 2.39.5