From 434573e8ed651f1544029241191ddce2b764a8e9 Mon Sep 17 00:00:00 2001 From: Anders Kaseorg Date: Fri, 4 Nov 2016 20:38:08 -0400 Subject: [PATCH] src/rx/rx_packet.c: Fix misleading indentation MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Fixes these warnings (errors with --enable-checking) from GCC 6.2: rx_packet.c: In function ‘rxi_ReceiveDebugPacket’: rx_packet.c:2009:9: error: this ‘if’ clause does not guard... [-Werror=misleading-indentation] if (rx_stats_active) ^~ rx_packet.c:2011:6: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the ‘if’ s = (afs_int32 *) & rx_stats; ^ rx_packet.c:2017:9: error: this ‘if’ clause does not guard... [-Werror=misleading-indentation] if (rx_stats_active) ^~ rx_packet.c:2019:6: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the ‘if’ rxi_SendDebugPacket(ap, asocket, ahost, aport, istack); ^~~~~~~~~~~~~~~~~~~ Reviewed-on: https://gerrit.openafs.org/12436 Reviewed-by: Benjamin Kaduk Tested-by: BuildBot (cherry picked from commit 0aeb8c17a2701169ddb7397d951c73cf361087c8) Change-Id: Ic7db23cecdcb7f02d1529326b336d62339af8460 Reviewed-on: https://gerrit.openafs.org/12483 Tested-by: BuildBot Reviewed-by: Benjamin Kaduk Reviewed-by: Stephan Wiesand --- src/rx/rx_packet.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/rx/rx_packet.c b/src/rx/rx_packet.c index 1a5f4df7a..24006d07c 100644 --- a/src/rx/rx_packet.c +++ b/src/rx/rx_packet.c @@ -2061,16 +2061,16 @@ rxi_ReceiveDebugPacket(struct rx_packet *ap, osi_socket asocket, return ap; /* Since its all int32s convert to network order with a loop. */ - if (rx_stats_active) - MUTEX_ENTER(&rx_stats_mutex); + if (rx_stats_active) + MUTEX_ENTER(&rx_stats_mutex); s = (afs_int32 *) & rx_stats; for (i = 0; i < sizeof(rx_stats) / sizeof(afs_int32); i++, s++) rx_PutInt32(ap, i * sizeof(afs_int32), htonl(*s)); tl = ap->length; ap->length = sizeof(rx_stats); - if (rx_stats_active) - MUTEX_EXIT(&rx_stats_mutex); + if (rx_stats_active) + MUTEX_EXIT(&rx_stats_mutex); rxi_SendDebugPacket(ap, asocket, ahost, aport, istack); ap->length = tl; break; -- 2.39.5