From 46a96ee06582178eb88e8ca1c7fbb33fae79b403 Mon Sep 17 00:00:00 2001 From: Jeffrey Altman Date: Mon, 17 Oct 2011 09:22:53 -0400 Subject: [PATCH] Windows: AFSEvaluateTargetByName free buffer if no return For consistency with other functions in AFSCommSupport modify AFSEvaluateTargetByName to free the DirEntry on completion if the caller has not provided an out parameter to accept it. Change-Id: Ic5b6cc655fd47b95493e6aadb7b23481d0187d5c Reviewed-on: http://gerrit.openafs.org/5624 Reviewed-by: Rod Widdowson Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman --- src/WINNT/afsrdr/kernel/lib/AFSCommSupport.cpp | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/WINNT/afsrdr/kernel/lib/AFSCommSupport.cpp b/src/WINNT/afsrdr/kernel/lib/AFSCommSupport.cpp index 8f5d334d5..3f05e8b93 100644 --- a/src/WINNT/afsrdr/kernel/lib/AFSCommSupport.cpp +++ b/src/WINNT/afsrdr/kernel/lib/AFSCommSupport.cpp @@ -1638,7 +1638,16 @@ AFSEvaluateTargetByName( IN GUID *AuthGroup, // Pass back the dir enum entry // - *DirEnumEntry = pDirEnumCB; + if( DirEnumEntry != NULL) + { + + *DirEnumEntry = pDirEnumCB; + } + else + { + + AFSExFreePool( pDirEnumCB); + } try_exit: -- 2.39.5