From 48908e2a932420fe67fe1065d55f7e458b5cd1c2 Mon Sep 17 00:00:00 2001 From: Derrick Brashear Date: Mon, 22 Feb 2010 12:15:15 -0500 Subject: [PATCH] analyze paranoia don't pass a null pointer to FindVolume in case one shows up Change-Id: I76258d8f8ca18c536e3faa776df3e06005fe2bc2 Reviewed-on: http://gerrit.openafs.org/1360 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear --- src/afs/afs_analyze.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/afs/afs_analyze.c b/src/afs/afs_analyze.c index 443fae378..e7e07b40d 100644 --- a/src/afs/afs_analyze.c +++ b/src/afs/afs_analyze.c @@ -458,8 +458,9 @@ afs_Analyze(register struct afs_conn *aconn, afs_int32 acode, if ((acode < 0) && (acode != VRESTARTING)) { if (acode == RX_CALL_TIMEOUT) { serversleft = afs_BlackListOnce(areq, afid, tsp); - tvp = afs_FindVolume(afid, READ_LOCK); - if (!tvp || (tvp->states & VRO)) + if (afid) + tvp = afs_FindVolume(afid, READ_LOCK); + if (!afid || !tvp || (tvp->states & VRO)) areq->idleError++; if ((serversleft == 0) && tvp && ((tvp->states & VRO) || (tvp->states & VBackup))) { -- 2.39.5