From 53da61120b65578e2a5de52f53eb3f47da37b06e Mon Sep 17 00:00:00 2001 From: Andrew Deason Date: Tue, 10 May 2011 13:45:26 -0500 Subject: [PATCH] libafs: GiveUpAllCallBacks at shutdown again Commit cee2c677d7de66a510d05978e3b41dcd5d8aca78 caused the cache manager to give up all callbacks at shutdown. But 76158df491f47de56d1febe1d1d2d17d316c9a74 removed the call to afs_FlushVCBs in afs_shutdown. Put it back. Reviewed-on: http://gerrit.openafs.org/4640 Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit 330cc7c83bf8470e1e63f6e6d514f1e82008f167) Change-Id: I9c2b309b482a735f5cce57aa7497b67858db2c3e Reviewed-on: http://gerrit.openafs.org/10855 Tested-by: Andrew Deason Tested-by: BuildBot Tested-by: Stephan Wiesand Reviewed-by: Benjamin Kaduk Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand --- src/afs/afs_call.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/afs/afs_call.c b/src/afs/afs_call.c index 7ba29659c..f15aa8076 100644 --- a/src/afs/afs_call.c +++ b/src/afs/afs_call.c @@ -1387,7 +1387,13 @@ afs_shutdown(void) if (afs_shuttingdown) return; + /* Give up all of our callbacks if we can. This must be done before setting + * afs_shuttingdown, since it calls afs_InitReq, which will fail if + * afs_shuttingdown is set. */ + afs_FlushVCBs(2); + afs_shuttingdown = 1; + if (afs_cold_shutdown) afs_warn("afs: COLD "); else -- 2.39.5