From 596ed7d29dd24e51c45ffef19dc2d05a45c2f29b Mon Sep 17 00:00:00 2001 From: Andrew Deason Date: Thu, 3 May 2012 12:40:40 -0500 Subject: [PATCH] vos setaddrs: notice unexpected errors Currently 'vos setaddrs' only prints a message and errors out if the VL_RegisterAddrs call fails with certain error codes (VL_MULTIPADDR and RXGEN_OPCODE). But if we get something else like an access error, we should of course print that out, instead of reporting success. Reviewed-on: http://gerrit.openafs.org/7322 Tested-by: BuildBot Reviewed-by: Chas Williams - CONTRACTOR Reviewed-by: Tom Keiser Reviewed-by: Derrick Brashear (cherry picked from commit 663185d62df501fb9d7a18e6ef329e4f53aa8854) Change-Id: I86b8729cd091007b84fb8b7bf19c58d477626686 Reviewed-on: http://gerrit.openafs.org/7489 Tested-by: BuildBot Reviewed-by: Derrick Brashear --- src/volser/vos.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/volser/vos.c b/src/volser/vos.c index 90b9e55c1..0dd7ec941 100644 --- a/src/volser/vos.c +++ b/src/volser/vos.c @@ -5461,13 +5461,13 @@ SetAddrs(struct cmd_syndesc *as, void *arock) if (vcode) { if (vcode == VL_MULTIPADDR) { fprintf(STDERR, "vos: VL_RegisterAddrs rpc failed; The IP address exists on a different server; repair it\n"); - PrintError("", vcode); - return vcode; } else if (vcode == RXGEN_OPCODE) { fprintf(STDERR, "vlserver doesn't support VL_RegisterAddrs rpc; ignored\n"); - PrintError("", vcode); - return vcode; + } else { + fprintf(STDERR, "vos: VL_RegisterAddrs rpc failed\n"); } + PrintError("", vcode); + return vcode; } if (verbose) { fprintf(STDOUT, "vos: Changed UUID with addresses:\n"); -- 2.39.5