From 604f7a2ad251d36410192d982b66fee76ae622f0 Mon Sep 17 00:00:00 2001 From: Simon Wilkinson Date: Mon, 4 Oct 2010 12:33:24 +0100 Subject: [PATCH] configure: Restore saved CFLAGS When we test for whether the C compiler can take the -fno-strength-reduce flag, we add the flag to CFLAGS to do so. However, we were not restoring the old value of this flag when we completed the test, and so we were always setting -fno-strength-reduce in the userspace compile. Previously, this was harmless, as we always overwrote CFLAGS, but if we're moving to a world where we honour the user's setting of CFLAGS, we need to not leak changes in this way. Reviewed-on: http://gerrit.openafs.org/2894 Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit 907521feb1b9c7a6c816866a672c7ab84dac6abd) Change-Id: Ie8c2a80b204754f1c17d9fa5e06903a7cdf7e4d2 Reviewed-on: http://gerrit.openafs.org/4004 Tested-by: BuildBot Reviewed-by: Marc Dionne Reviewed-by: Derrick Brashear --- src/cf/linux-test5.m4 | 1 + 1 file changed, 1 insertion(+) diff --git a/src/cf/linux-test5.m4 b/src/cf/linux-test5.m4 index 0b86d2e75..90c312cba 100644 --- a/src/cf/linux-test5.m4 +++ b/src/cf/linux-test5.m4 @@ -40,6 +40,7 @@ AC_DEFUN([OPENAFS_GCC_NEEDS_NO_STRENGTH_REDUCE], [ [int x;], [openafs_cv_gcc_needs_no_strength_reduce=yes], [openafs_cv_gcc_needs_no_strength_reduce=no]) + CFLAGS="$save_CFLAGS" ]) AS_IF([test x$openafs_cv_gcc_needs_no_strength_reduce = xyes], [LINUX_GCC_KOPTS="$LINUX_GCC_KOPTS -fno-strength-reduce"]) -- 2.39.5