From 6dd07af215e2cc75cb7c902b5a06920a5ee5235c Mon Sep 17 00:00:00 2001 From: Simon Wilkinson Date: Sat, 12 Jun 2010 10:26:09 +0100 Subject: [PATCH] viced: CopyOnWrite2 shouldn't return undefined val Unless CopyOnWrite2 encounters the condition where (rdlen != length) || (wrlen !=length) it will never set a value for the 'rc' return code, and so return with an undefined value. Looking at the code, it looks like rc should be 0 in all other situations, so this patch provides a default value. Caught by clang-analyzer Change-Id: If3e528f3d66abb3dde6da2304084f7698c05b863 Reviewed-on: http://gerrit.openafs.org/2141 Reviewed-by: Russ Allbery Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear --- src/viced/afsfileprocs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/viced/afsfileprocs.c b/src/viced/afsfileprocs.c index b49b4e44a..2b36f6237 100644 --- a/src/viced/afsfileprocs.c +++ b/src/viced/afsfileprocs.c @@ -1269,7 +1269,7 @@ CopyOnWrite2(FdHandle_t *targFdP, FdHandle_t *newFdP, afs_foff_t off, size_t length; ssize_t rdlen; ssize_t wrlen; - int rc; + int rc = 0; FDH_SEEK(targFdP, off, SEEK_SET); FDH_SEEK(newFdP, off, SEEK_SET); -- 2.39.5