From 6e167d4646992e95d294927b238e21f39b1169e3 Mon Sep 17 00:00:00 2001 From: Benjamin Kaduk Date: Mon, 6 Oct 2014 22:54:09 -0400 Subject: [PATCH] Remove unused -k argument to fileserver It has been unused since the LWP fileserver was removed. It was used to set the LWP stack size. Change-Id: I2ffd3a2f02049a307b668a46b62b31dc9bc128a8 Reviewed-on: http://gerrit.openafs.org/11527 Tested-by: BuildBot Reviewed-by: Chas Williams - CONTRACTOR Reviewed-by: D Brashear --- doc/man-pages/pod8/fragments/fileserver-cautions.pod | 9 +++------ doc/man-pages/pod8/fragments/fileserver-options.pod | 5 ----- src/viced/viced.c | 5 ----- 3 files changed, 3 insertions(+), 16 deletions(-) diff --git a/doc/man-pages/pod8/fragments/fileserver-cautions.pod b/doc/man-pages/pod8/fragments/fileserver-cautions.pod index 5d9230a33..09414c88b 100644 --- a/doc/man-pages/pod8/fragments/fileserver-cautions.pod +++ b/doc/man-pages/pod8/fragments/fileserver-cautions.pod @@ -13,12 +13,9 @@ Server to demand-attach or vice versa, you will need to stop and remove the C or C node in F and create a new node of the appropriate type. See L for more information. -Do not use the B<-k> and B<-w> arguments, which are intended for use -by the OpenAFS developers only. Changing them from their default -values can result in unpredictable File Server behavior. In any case, -on many operating systems the File Server uses native threads rather -than the LWP threads, so using the B<-k> argument to set the number of -LWP threads has no effect. +Do not use the B<-w> argument, which is intended for use +by the OpenAFS developers only. Changing it from its default +values can result in unpredictable File Server behavior. Do not specify both the B<-spare> and B<-pctspare> arguments. Doing so causes the File Server to exit, leaving an error message in the diff --git a/doc/man-pages/pod8/fragments/fileserver-options.pod b/doc/man-pages/pod8/fragments/fileserver-options.pod index 2028e52ab..67b754e56 100644 --- a/doc/man-pages/pod8/fragments/fileserver-options.pod +++ b/doc/man-pages/pod8/fragments/fileserver-options.pod @@ -206,11 +206,6 @@ server machine. Combine this flag with any option except the B<-L> flag; omit both flags to set values suitable for a medium-sized file server machine. -=item B<-k> > - -Sets the LWP stack size in units of 1 kilobyte. Do not use this argument, -and in particular do not specify a value less than the default of C<24>. - =item B<-realm> > Defines the Kerberos realm name for the File Server to use. If this diff --git a/src/viced/viced.c b/src/viced/viced.c index bab39f915..b1359164a 100644 --- a/src/viced/viced.c +++ b/src/viced/viced.c @@ -134,7 +134,6 @@ afs_int32 implicitAdminRights = PRSFS_LOOKUP; /* The ADMINISTER right is * already implied */ afs_int32 readonlyServer = 0; -int stack = 24; int stackSize = 24000; int fiveminutes = 300; /* 5 minutes. Change this for debugging only */ int CurrentConnections = 0; @@ -955,7 +954,6 @@ enum optionsList { OPT_vlruinterval, OPT_vlrumax, OPT_unsafe_nosalvage, - OPT_stack, OPT_cbwait, OPT_novbc, OPT_auditlog, @@ -1102,8 +1100,6 @@ ParseArgs(int argc, char *argv[]) #endif /* unrecommend options - should perhaps be CMD_HIDE */ - cmd_AddParmAtOffset(opts, OPT_stack, "-k", CMD_SINGLE, CMD_OPTIONAL, - "stack size"); cmd_AddParmAtOffset(opts, OPT_cbwait, "-w", CMD_SINGLE, CMD_OPTIONAL, "callback wait interval"); cmd_AddParmAtOffset(opts, OPT_novbc, "-novbc", CMD_SINGLE, CMD_FLAG, @@ -1340,7 +1336,6 @@ ParseArgs(int argc, char *argv[]) cmd_OptionAsFlag(opts, OPT_unsafe_nosalvage, &unsafe_attach); #endif /* AFS_DEMAND_ATTACH_FS */ - cmd_OptionAsInt(opts, OPT_stack, &stack); cmd_OptionAsInt(opts, OPT_cbwait, &fiveminutes); cmd_OptionAsFlag(opts, OPT_novbc, &novbc); -- 2.39.5