From 71e3c5d6ca4e1d75504249693fe9f4587c870487 Mon Sep 17 00:00:00 2001 From: Simon Wilkinson Date: Fri, 30 Mar 2012 19:40:30 +0100 Subject: [PATCH] xdr: Len can never be negative The len parameter to xdr_len is unsigned, so can never be negative. Don't bother testing to see if it is negative, so that clang likes us again. Reviewed-on: http://gerrit.openafs.org/7089 Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit f1842bcb87c84e8862ca521f491215e42ce1ee2a) Change-Id: I1cf030b8e9f79bdf867bcaecfd59d8ade7fc8c25 Reviewed-on: http://gerrit.openafs.org/10734 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand --- src/rx/xdr_mem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/rx/xdr_mem.c b/src/rx/xdr_mem.c index 0dd5daa0c..558b4dbf8 100644 --- a/src/rx/xdr_mem.c +++ b/src/rx/xdr_mem.c @@ -189,7 +189,7 @@ xdrmem_inline(XDR *xdrs, u_int len) { afs_int32 *buf = 0; - if (len >= 0 && xdrs->x_handy >= len) { + if (xdrs->x_handy >= len) { xdrs->x_handy -= len; buf = (afs_int32 *) xdrs->x_private; xdrs->x_private += len; -- 2.39.5