From 7fd98901620cfb2f44f53b1d717834e39959c538 Mon Sep 17 00:00:00 2001 From: Jeffrey Altman Date: Tue, 16 Oct 2012 20:26:43 -0400 Subject: [PATCH] Windows: OpenTargetDirectory AFSInitFcb Reparse Test In AFSOpenTargetDirectory the test to determine if AFSInitFcb allocated a FCB or returned an existing one (STATUS_REPARSE) was reversed. If AFSInitFcb was called and AFSOpenTargetDirectory eventually failed, an in use FCB would be freed. Change-Id: Ie5974fee5202685575f286fe4fef43dfdc0698cb Reviewed-on: http://gerrit.openafs.org/8244 Tested-by: BuildBot Reviewed-by: Rod Widdowson Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman --- src/WINNT/afsrdr/kernel/lib/AFSCreate.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/WINNT/afsrdr/kernel/lib/AFSCreate.cpp b/src/WINNT/afsrdr/kernel/lib/AFSCreate.cpp index cfaae808c..8f8d9949b 100644 --- a/src/WINNT/afsrdr/kernel/lib/AFSCreate.cpp +++ b/src/WINNT/afsrdr/kernel/lib/AFSCreate.cpp @@ -2308,7 +2308,7 @@ AFSOpenTargetDirectory( IN PIRP Irp, AFSDbgLogMsg( AFS_SUBSYSTEM_FILE_PROCESSING, AFS_TRACE_LEVEL_ERROR, - "AFSProcessCreate (%08lX) Failed to initialize fcb %wZ Status %08lX\n", + "AFSOpenTargetDirectory (%08lX) Failed to initialize fcb %wZ Status %08lX\n", Irp, &ParentDirectoryCB->NameInformation.FileName, ntStatus); @@ -2316,7 +2316,7 @@ AFSOpenTargetDirectory( IN PIRP Irp, try_return( ntStatus); } - if ( ntStatus == STATUS_REPARSE) + if ( ntStatus != STATUS_REPARSE) { bAllocatedFcb = TRUE; -- 2.39.5