From 871c19fc168dec5d22da764ca64decbe19f3b1e5 Mon Sep 17 00:00:00 2001 From: Ben Kaduk Date: Fri, 18 Jul 2014 15:19:24 -0400 Subject: [PATCH] FBSD: adhere to gop_lookupname() semantics The current semantics are that gop_lookupname() returns an unlocked vnode; the previous code was written to a different semantic that a locked vnode should be returned. This makes a disk cache more likely to work on FreeBSD, but such configurations remain not very tested. Reviewed-on: http://gerrit.openafs.org/11317 Tested-by: BuildBot Reviewed-by: D Brashear (cherry picked from commit 774d77e056515ae3e87c8f0be8e133c3cdb36bbb) Change-Id: I4ae9c269412c2ce6b9ec39a841ea87f27630591e Reviewed-on: http://gerrit.openafs.org/11448 Tested-by: BuildBot Reviewed-by: Jeffrey Altman Reviewed-by: Stephan Wiesand --- src/afs/FBSD/osi_misc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/afs/FBSD/osi_misc.c b/src/afs/FBSD/osi_misc.c index 5fdd4612e..d0d862dbf 100644 --- a/src/afs/FBSD/osi_misc.c +++ b/src/afs/FBSD/osi_misc.c @@ -32,9 +32,9 @@ osi_lookupname(char *aname, enum uio_seg seg, int followlink, AFS_GUNLOCK(); #if __FreeBSD_version >= 1000021 /* MPSAFE is gone for good! */ - flags = LOCKLEAF; + flags = 0; #else - flags = LOCKLEAF | MPSAFE; /* namei must take Giant if needed */ + flags = MPSAFE; /* namei must take Giant if needed */ #endif if (followlink) flags |= FOLLOW; -- 2.39.5