From 8bd21b891f862a8754cf32cc6d85707cdfdb52fd Mon Sep 17 00:00:00 2001 From: Simon Wilkinson Date: Fri, 22 Feb 2013 09:51:24 +0000 Subject: [PATCH] kauth: Don't ignore GetExtendedCellInfo failures Don't ignore a failure from afsconf_GetExtendedCellInfo, as it will leave buffers that we later read uninitialised. Caught by clang-analyzer Reviewed-on: http://gerrit.openafs.org/9180 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Jeffrey Altman (cherry picked from commit 5cefa0247fe4f22f769e366a207fb177ee8fb94f) Change-Id: I613a371f1f0ab1a739966e81965661d6cbff8e5e Reviewed-on: http://gerrit.openafs.org/9531 Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand Reviewed-by: Derrick Brashear Tested-by: BuildBot --- src/kauth/kaserver.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/kauth/kaserver.c b/src/kauth/kaserver.c index db70a9c1f..074656527 100644 --- a/src/kauth/kaserver.c +++ b/src/kauth/kaserver.c @@ -321,9 +321,13 @@ main(int argc, char *argv[]) "Migrating to a Kerberos 5 KDC is advised. " "http://www.openafs.org/no-more-des.html\n")); - code = - afsconf_GetExtendedCellInfo(KA_conf, cell, AFSCONF_KAUTHSERVICE, - &cellinfo, clones); + code = afsconf_GetExtendedCellInfo(KA_conf, cell, AFSCONF_KAUTHSERVICE, + &cellinfo, clones); + if (code) { + afs_com_err(whoami, code, "Couldn't read cell configuration"); + exit(1); + } + if (servers) { if ((code = ubik_ParseServerList(argc, argv, &myHost, serverList))) { afs_com_err(whoami, code, "Couldn't parse server list"); -- 2.39.5