From 8bf77854874cff730d0cf38a532ebf4ea0f2bc30 Mon Sep 17 00:00:00 2001 From: Russ Allbery Date: Sat, 29 Jun 2013 14:29:06 -0700 Subject: [PATCH] Fix restorevol sanity check on afs_int32 restorevol reads various values of different lengths into an afs_int32 and does a sanity check to ensure that there is enough room to store the desired value length. However, the check was done against the wrong variable, making it ineffective. This check is unlikely to ever trigger, but fix it just in case. Change-Id: Ia81bd9ff9a2ce8e2d93af384c8e8c664f5434d5e Reviewed-on: http://gerrit.openafs.org/10026 Tested-by: BuildBot Reviewed-by: Jeffrey Altman Reviewed-by: Derrick Brashear --- src/volser/restorevol.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/volser/restorevol.c b/src/volser/restorevol.c index f4a54b7bb..c4e0ff7aa 100644 --- a/src/volser/restorevol.c +++ b/src/volser/restorevol.c @@ -77,8 +77,8 @@ readvalue(int size) ptr = (char *)&value; s = sizeof(value) - size; - if (size < 0) { - fprintf(stderr, "Too much data in afs_int32\n"); + if (s < 0) { + fprintf(stderr, "Too much data for afs_int32\n"); return 0; } -- 2.39.5