From 908105fe8d51551e45692de4e145022138a0356c Mon Sep 17 00:00:00 2001 From: Simon Wilkinson Date: Sat, 2 Mar 2013 11:49:13 +0000 Subject: [PATCH] fstrace: Don't read uninitialised data The pftix variable points to the next free element in the printfTypes array, so when we iterate through that array to read that data back, we should stop when our iterator equals pftix, not when it is greater than it. Caught by coverity (#986013) Change-Id: Ie08ebdd28cdde6647e91da5c5f67512096ecb34c Reviewed-on: http://gerrit.openafs.org/9442 Reviewed-by: Derrick Brashear Tested-by: BuildBot Reviewed-by: Jeffrey Altman --- src/venus/fstrace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/venus/fstrace.c b/src/venus/fstrace.c index 9020e6968..588415ed2 100644 --- a/src/venus/fstrace.c +++ b/src/venus/fstrace.c @@ -157,7 +157,7 @@ CheckTypes(char *bufferp, int *typesp, int typeCount, char *outMsgBuffer) * check the type descriptor. */ inPercent = 0; - if (tix > typeCount) + if (tix >= typeCount) return 0; /* no more type descriptors left */ if (tc == 's') { if (typesp[tix] != 1) /* not a string descriptor */ -- 2.39.5