From 91eec4d85016b009a9661e98651dfbaa32618d3d Mon Sep 17 00:00:00 2001 From: Andrew Deason Date: Thu, 22 Jul 2010 13:43:17 -0500 Subject: [PATCH] salvage: Zero root/readme vnodes before writing Previously we were writing out the root and readme vnodes with uninitialized 'lock' structures, when we create a new root dir for attaching orphans. Just use calloc so we ensure that everything is zeroed before writing it out. Change-Id: I3c7712254aaef8731be95ea63530af05438d96a6 Reviewed-on: http://gerrit.openafs.org/2469 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear --- src/vol/vol-salvage.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/vol/vol-salvage.c b/src/vol/vol-salvage.c index 408bc5ead..e273f4056 100644 --- a/src/vol/vol-salvage.c +++ b/src/vol/vol-salvage.c @@ -3472,7 +3472,7 @@ CreateReadme(VolumeDiskData *volHeader, IHandle_t *alinkH, } /* create the vnode and write it out */ - rvnode = malloc(SIZEOF_SMALLDISKVNODE); + rvnode = calloc(1, SIZEOF_SMALLDISKVNODE); if (!rvnode) { Log("CreateRootDir: error alloc'ing memory\n"); goto error; @@ -3630,7 +3630,7 @@ CreateRootDir(VolumeDiskData *volHeader, IHandle_t *alinkH, VolumeId vid, DZap((void *)&rootdir->dirHandle); /* create the new root dir vnode */ - rootvnode = malloc(SIZEOF_LARGEDISKVNODE); + rootvnode = calloc(1, SIZEOF_LARGEDISKVNODE); if (!rootvnode) { Log("CreateRootDir: malloc failed\n"); goto error; -- 2.39.5