From 93d674d702ab1bd452b139f5ba628db2c082f536 Mon Sep 17 00:00:00 2001 From: Rod Widdowson Date: Sun, 23 Dec 2012 14:48:14 +0000 Subject: [PATCH] Windows: more warnings on kernel builds This is the same sort of changes a per git commit 8a4094e9ffa5d0f96501817c8ffd3cc8dc7ec62b but this time for the fs tree. Again most of the work is UNREFERENCED_PARAMETER, initialize variables where the compiler lacks the smarts and remove unused locals. Change-Id: Id67246e8aaee292cb6f02833e9960f9545c55101 Reviewed-on: http://gerrit.openafs.org/8823 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman --- .../afsrdr/kernel/fs/AFSAuthGroupSupport.cpp | 3 - .../afsrdr/kernel/fs/AFSBTreeSupport.cpp | 1 - src/WINNT/afsrdr/kernel/fs/AFSCleanup.cpp | 4 +- src/WINNT/afsrdr/kernel/fs/AFSClose.cpp | 1 - src/WINNT/afsrdr/kernel/fs/AFSCommSupport.cpp | 7 +- src/WINNT/afsrdr/kernel/fs/AFSDirControl.cpp | 2 - .../afsrdr/kernel/fs/AFSFastIoSupport.cpp | 134 ++++++++++++++++++ src/WINNT/afsrdr/kernel/fs/AFSFileInfo.cpp | 1 - src/WINNT/afsrdr/kernel/fs/AFSGeneric.cpp | 14 +- src/WINNT/afsrdr/kernel/fs/AFSInit.cpp | 3 +- .../kernel/fs/AFSInternalDevControl.cpp | 1 + .../afsrdr/kernel/fs/AFSLibrarySupport.cpp | 2 + .../afsrdr/kernel/fs/AFSProcessSupport.cpp | 4 +- src/WINNT/afsrdr/kernel/fs/AFSQuota.cpp | 2 + src/WINNT/afsrdr/kernel/fs/AFSRDRSupport.cpp | 7 +- src/WINNT/afsrdr/kernel/fs/AFSShutdown.cpp | 1 + .../afsrdr/kernel/fs/AFSSystemControl.cpp | 1 + src/WINNT/afsrdr/kernel/fs/AFSVolumeInfo.cpp | 2 +- 18 files changed, 157 insertions(+), 33 deletions(-) diff --git a/src/WINNT/afsrdr/kernel/fs/AFSAuthGroupSupport.cpp b/src/WINNT/afsrdr/kernel/fs/AFSAuthGroupSupport.cpp index 5656ad775..e66054f9c 100644 --- a/src/WINNT/afsrdr/kernel/fs/AFSAuthGroupSupport.cpp +++ b/src/WINNT/afsrdr/kernel/fs/AFSAuthGroupSupport.cpp @@ -429,7 +429,6 @@ AFSCreateSetProcessAuthGroup( AFSAuthGroupRequestCB *CreateSetAuthGroup) AFSProcessAuthGroupCB *pAuthGroup = NULL, *pLastAuthGroup = NULL; ULONG ulSessionId = 0; ULONGLONG ullTableHash = 0; - GUID stAuthGroup; UNICODE_STRING uniCallerSID; BOOLEAN bImpersonation = FALSE; @@ -1064,7 +1063,6 @@ AFSResetActiveProcessAuthGroup( IN IN AFSAuthGroupRequestCB *AuthGroup) { NTSTATUS ntStatus = STATUS_SUCCESS; - GUID *pAuthGroup = NULL; AFSProcessCB *pProcessCB = NULL; AFSThreadCB *pThreadCB = NULL; AFSDeviceExt *pDeviceExt = (AFSDeviceExt *)AFSDeviceObject->DeviceExtension; @@ -1184,7 +1182,6 @@ AFSCreateAuthGroupForSIDorLogonSession( IN AFSAuthGroupRequestCB *AuthGroupReque AFSSIDEntryCB *pSIDEntryCB = NULL; ULONG ulSessionId = 0; ULONGLONG ullTableHash = 0; - GUID stAuthGroup; UNICODE_STRING uniCallerSID; UNICODE_STRING uniGUID; BOOLEAN bLocalSystem = FALSE; diff --git a/src/WINNT/afsrdr/kernel/fs/AFSBTreeSupport.cpp b/src/WINNT/afsrdr/kernel/fs/AFSBTreeSupport.cpp index 13bb42f71..64b3baced 100644 --- a/src/WINNT/afsrdr/kernel/fs/AFSBTreeSupport.cpp +++ b/src/WINNT/afsrdr/kernel/fs/AFSBTreeSupport.cpp @@ -45,7 +45,6 @@ AFSLocateHashEntry( IN AFSBTreeEntry *TopNode, { NTSTATUS ntStatus = STATUS_SUCCESS; - AFSBTreeEntry *pEntry = NULL; AFSBTreeEntry *pCurrentEntry = NULL; pCurrentEntry = TopNode; diff --git a/src/WINNT/afsrdr/kernel/fs/AFSCleanup.cpp b/src/WINNT/afsrdr/kernel/fs/AFSCleanup.cpp index 96e7502bc..0ea29c464 100644 --- a/src/WINNT/afsrdr/kernel/fs/AFSCleanup.cpp +++ b/src/WINNT/afsrdr/kernel/fs/AFSCleanup.cpp @@ -56,7 +56,6 @@ AFSCleanup( IN PDEVICE_OBJECT DeviceObject, { NTSTATUS ntStatus = STATUS_SUCCESS; - AFSDeviceExt *pDeviceExt = (AFSDeviceExt *)DeviceObject->DeviceExtension; IO_STACK_LOCATION *pIrpSp = IoGetCurrentIrpStackLocation( Irp); __try @@ -119,9 +118,8 @@ NTSTATUS AFSCommonCleanup( IN PDEVICE_OBJECT DeviceObject, IN PIRP Irp) { - + UNREFERENCED_PARAMETER(DeviceObject); NTSTATUS ntStatus = STATUS_SUCCESS; - AFSDeviceExt *pDeviceExt = (AFSDeviceExt *)DeviceObject->DeviceExtension; IO_STACK_LOCATION *pIrpSp = IoGetCurrentIrpStackLocation( Irp); PFILE_OBJECT pFileObject = NULL; AFSDeviceExt *pControlDeviceExt = (AFSDeviceExt *)AFSDeviceObject->DeviceExtension; diff --git a/src/WINNT/afsrdr/kernel/fs/AFSClose.cpp b/src/WINNT/afsrdr/kernel/fs/AFSClose.cpp index 64e8168df..609adb76f 100644 --- a/src/WINNT/afsrdr/kernel/fs/AFSClose.cpp +++ b/src/WINNT/afsrdr/kernel/fs/AFSClose.cpp @@ -95,7 +95,6 @@ AFSCommonClose( IN PDEVICE_OBJECT DeviceObject, { NTSTATUS ntStatus = STATUS_SUCCESS; - ULONG ulRequestType = 0; IO_STACK_LOCATION *pIrpSp = IoGetCurrentIrpStackLocation( Irp); AFSDeviceExt *pDeviceExt = NULL; AFSDeviceExt *pControlDeviceExt = (AFSDeviceExt *)AFSDeviceObject->DeviceExtension; diff --git a/src/WINNT/afsrdr/kernel/fs/AFSCommSupport.cpp b/src/WINNT/afsrdr/kernel/fs/AFSCommSupport.cpp index b049a00b9..c9f8528ea 100644 --- a/src/WINNT/afsrdr/kernel/fs/AFSCommSupport.cpp +++ b/src/WINNT/afsrdr/kernel/fs/AFSCommSupport.cpp @@ -394,7 +394,6 @@ AFSProcessControlRequest( IN PIRP Irp) ULONG ulIoControlCode; BOOLEAN bCompleteRequest = TRUE; AFSDeviceExt *pDevExt = (AFSDeviceExt *)AFSDeviceObject->DeviceExtension; - ULONG ulBytesProcessed = 0; __try { @@ -903,7 +902,6 @@ void AFSCleanupIrpPool() { - NTSTATUS ntStatus = STATUS_SUCCESS; AFSPoolEntry *pEntry = NULL, *pNextEntry = NULL; AFSDeviceExt *pDevExt = (AFSDeviceExt *)AFSDeviceObject->DeviceExtension; AFSCommSrvcCB *pCommSrvc = (AFSCommSrvcCB *)&pDevExt->Specific.Control.CommServiceCB; @@ -967,7 +965,7 @@ AFSCleanupIrpPool() // Here we need to complete the irp, cancelled, and delete the data block // - pEntry->ResultStatus = STATUS_CANCELLED; + pEntry->ResultStatus = (ULONG) STATUS_CANCELLED; KeSetEvent( &pEntry->Event, 0, @@ -1013,7 +1011,7 @@ AFSCleanupIrpPool() pNextEntry = pEntry->fLink; - pEntry->ResultStatus = STATUS_CANCELLED; + pEntry->ResultStatus = (ULONG) STATUS_CANCELLED; // // Here we will set the event of the requestor and let the blocked thread @@ -1481,7 +1479,6 @@ AFSProcessIrpResult( IN PIRP Irp) NTSTATUS ntStatus = STATUS_SUCCESS; AFSDeviceExt *pDevExt = (AFSDeviceExt *)AFSDeviceObject->DeviceExtension; - IO_STACK_LOCATION *pIrpSp = IoGetCurrentIrpStackLocation( Irp); AFSCommSrvcCB *pCommSrvc = NULL; AFSPoolEntry *pCurrentEntry = NULL; AFSCommResult *pResult = NULL; diff --git a/src/WINNT/afsrdr/kernel/fs/AFSDirControl.cpp b/src/WINNT/afsrdr/kernel/fs/AFSDirControl.cpp index 0f9f9529a..c47da01e5 100644 --- a/src/WINNT/afsrdr/kernel/fs/AFSDirControl.cpp +++ b/src/WINNT/afsrdr/kernel/fs/AFSDirControl.cpp @@ -56,8 +56,6 @@ AFSDirControl( IN PDEVICE_OBJECT DeviceObject, { NTSTATUS ntStatus = STATUS_SUCCESS; - ULONG ulRequestType = 0; - IO_STACK_LOCATION *pIrpSp = IoGetCurrentIrpStackLocation( Irp); AFSDeviceExt *pControlDeviceExt = (AFSDeviceExt *)AFSDeviceObject->DeviceExtension; __try diff --git a/src/WINNT/afsrdr/kernel/fs/AFSFastIoSupport.cpp b/src/WINNT/afsrdr/kernel/fs/AFSFastIoSupport.cpp index ea87c1464..ecc75cc25 100644 --- a/src/WINNT/afsrdr/kernel/fs/AFSFastIoSupport.cpp +++ b/src/WINNT/afsrdr/kernel/fs/AFSFastIoSupport.cpp @@ -48,6 +48,14 @@ AFSFastIoCheckIfPossible( IN struct _FILE_OBJECT *FileObject, OUT PIO_STATUS_BLOCK IoStatus, IN struct _DEVICE_OBJECT *DeviceObject) { + UNREFERENCED_PARAMETER(FileObject); + UNREFERENCED_PARAMETER(FileOffset); + UNREFERENCED_PARAMETER(Length); + UNREFERENCED_PARAMETER(Wait); + UNREFERENCED_PARAMETER(LockKey); + UNREFERENCED_PARAMETER(CheckForReadOperation); + UNREFERENCED_PARAMETER(IoStatus); + UNREFERENCED_PARAMETER(DeviceObject); BOOLEAN bStatus = FALSE; @@ -65,6 +73,15 @@ AFSFastIoRead( IN struct _FILE_OBJECT *FileObject, IN struct _DEVICE_OBJECT *DeviceObject) { + UNREFERENCED_PARAMETER(FileObject); + UNREFERENCED_PARAMETER(FileOffset); + UNREFERENCED_PARAMETER(Length); + UNREFERENCED_PARAMETER(Wait); + UNREFERENCED_PARAMETER(LockKey); + UNREFERENCED_PARAMETER(Buffer); + UNREFERENCED_PARAMETER(IoStatus); + UNREFERENCED_PARAMETER(DeviceObject); + BOOLEAN bStatus = FALSE; return bStatus; @@ -81,6 +98,15 @@ AFSFastIoWrite( IN struct _FILE_OBJECT *FileObject, IN struct _DEVICE_OBJECT *DeviceObject) { + UNREFERENCED_PARAMETER(FileObject); + UNREFERENCED_PARAMETER(FileOffset); + UNREFERENCED_PARAMETER(Length); + UNREFERENCED_PARAMETER(Wait); + UNREFERENCED_PARAMETER(LockKey); + UNREFERENCED_PARAMETER(Buffer); + UNREFERENCED_PARAMETER(IoStatus); + UNREFERENCED_PARAMETER(DeviceObject); + BOOLEAN bStatus = FALSE; return bStatus; @@ -93,6 +119,11 @@ AFSFastIoQueryBasicInfo( IN struct _FILE_OBJECT *FileObject, OUT PIO_STATUS_BLOCK IoStatus, IN struct _DEVICE_OBJECT *DeviceObject) { + UNREFERENCED_PARAMETER(FileObject); + UNREFERENCED_PARAMETER(Wait); + UNREFERENCED_PARAMETER(Buffer); + UNREFERENCED_PARAMETER(IoStatus); + UNREFERENCED_PARAMETER(DeviceObject); BOOLEAN bStatus = FALSE; @@ -106,6 +137,11 @@ AFSFastIoQueryStandardInfo( IN struct _FILE_OBJECT *FileObject, OUT PIO_STATUS_BLOCK IoStatus, IN struct _DEVICE_OBJECT *DeviceObject) { + UNREFERENCED_PARAMETER(FileObject); + UNREFERENCED_PARAMETER(Wait); + UNREFERENCED_PARAMETER(Buffer); + UNREFERENCED_PARAMETER(IoStatus); + UNREFERENCED_PARAMETER(DeviceObject); BOOLEAN bStatus = FALSE; @@ -123,6 +159,15 @@ AFSFastIoLock( IN struct _FILE_OBJECT *FileObject, OUT PIO_STATUS_BLOCK IoStatus, IN struct _DEVICE_OBJECT *DeviceObject) { + UNREFERENCED_PARAMETER(FileObject); + UNREFERENCED_PARAMETER(FileOffset); + UNREFERENCED_PARAMETER(Length); + UNREFERENCED_PARAMETER(ProcessId); + UNREFERENCED_PARAMETER(Key); + UNREFERENCED_PARAMETER(FailImmediately); + UNREFERENCED_PARAMETER(ExclusiveLock); + UNREFERENCED_PARAMETER(IoStatus); + UNREFERENCED_PARAMETER(DeviceObject); BOOLEAN bStatus = FALSE; @@ -138,6 +183,13 @@ AFSFastIoUnlockSingle( IN struct _FILE_OBJECT *FileObject, OUT PIO_STATUS_BLOCK IoStatus, IN struct _DEVICE_OBJECT *DeviceObject) { + UNREFERENCED_PARAMETER(FileObject); + UNREFERENCED_PARAMETER(FileOffset); + UNREFERENCED_PARAMETER(Length); + UNREFERENCED_PARAMETER(ProcessId); + UNREFERENCED_PARAMETER(Key); + UNREFERENCED_PARAMETER(IoStatus); + UNREFERENCED_PARAMETER(DeviceObject); BOOLEAN bStatus = FALSE; @@ -150,6 +202,10 @@ AFSFastIoUnlockAll( IN struct _FILE_OBJECT *FileObject, OUT PIO_STATUS_BLOCK IoStatus, IN struct _DEVICE_OBJECT *DeviceObject) { + UNREFERENCED_PARAMETER(FileObject); + UNREFERENCED_PARAMETER(ProcessId); + UNREFERENCED_PARAMETER(IoStatus); + UNREFERENCED_PARAMETER(DeviceObject); BOOLEAN bStatus = FALSE; @@ -163,6 +219,11 @@ AFSFastIoUnlockAllByKey( IN struct _FILE_OBJECT *FileObject, OUT PIO_STATUS_BLOCK IoStatus, IN struct _DEVICE_OBJECT *DeviceObject) { + UNREFERENCED_PARAMETER(FileObject); + UNREFERENCED_PARAMETER(ProcessId); + UNREFERENCED_PARAMETER(Key); + UNREFERENCED_PARAMETER(IoStatus); + UNREFERENCED_PARAMETER(DeviceObject); BOOLEAN bStatus = FALSE; @@ -180,6 +241,15 @@ AFSFastIoDevCtrl( IN struct _FILE_OBJECT *FileObject, OUT PIO_STATUS_BLOCK IoStatus, IN struct _DEVICE_OBJECT *DeviceObject) { + UNREFERENCED_PARAMETER(FileObject); + UNREFERENCED_PARAMETER(Wait); + UNREFERENCED_PARAMETER(InputBuffer); + UNREFERENCED_PARAMETER(InputBufferLength); + UNREFERENCED_PARAMETER(OutputBuffer); + UNREFERENCED_PARAMETER(OutputBufferLength); + UNREFERENCED_PARAMETER(IoControlCode); + UNREFERENCED_PARAMETER(IoStatus); + UNREFERENCED_PARAMETER(DeviceObject); BOOLEAN bStatus = FALSE; @@ -229,6 +299,8 @@ VOID AFSFastIoDetachDevice( IN struct _DEVICE_OBJECT *SourceDevice, IN struct _DEVICE_OBJECT *TargetDevice) { + UNREFERENCED_PARAMETER(SourceDevice); + UNREFERENCED_PARAMETER(TargetDevice); return; } @@ -240,6 +312,11 @@ AFSFastIoQueryNetworkOpenInfo( IN struct _FILE_OBJECT *FileObject, OUT struct _IO_STATUS_BLOCK *IoStatus, IN struct _DEVICE_OBJECT *DeviceObject) { + UNREFERENCED_PARAMETER(FileObject); + UNREFERENCED_PARAMETER(Wait); + UNREFERENCED_PARAMETER(Buffer); + UNREFERENCED_PARAMETER(IoStatus); + UNREFERENCED_PARAMETER(DeviceObject); BOOLEAN bStatus = FALSE; @@ -255,6 +332,13 @@ AFSFastIoMdlRead( IN struct _FILE_OBJECT *FileObject, OUT PIO_STATUS_BLOCK IoStatus, IN struct _DEVICE_OBJECT *DeviceObject) { + UNREFERENCED_PARAMETER(FileObject); + UNREFERENCED_PARAMETER(FileOffset); + UNREFERENCED_PARAMETER(Length); + UNREFERENCED_PARAMETER(LockKey); + UNREFERENCED_PARAMETER(MdlChain); + UNREFERENCED_PARAMETER(IoStatus); + UNREFERENCED_PARAMETER(DeviceObject); BOOLEAN bStatus = FALSE; @@ -266,6 +350,9 @@ AFSFastIoMdlReadComplete( IN struct _FILE_OBJECT *FileObject, IN PMDL MdlChain, IN struct _DEVICE_OBJECT *DeviceObject) { + UNREFERENCED_PARAMETER(FileObject); + UNREFERENCED_PARAMETER(MdlChain); + UNREFERENCED_PARAMETER(DeviceObject); BOOLEAN bStatus = FALSE; @@ -281,6 +368,13 @@ AFSFastIoPrepareMdlWrite( IN struct _FILE_OBJECT *FileObject, OUT PIO_STATUS_BLOCK IoStatus, IN struct _DEVICE_OBJECT *DeviceObject) { + UNREFERENCED_PARAMETER(FileObject); + UNREFERENCED_PARAMETER(FileOffset); + UNREFERENCED_PARAMETER(Length); + UNREFERENCED_PARAMETER(LockKey); + UNREFERENCED_PARAMETER(MdlChain); + UNREFERENCED_PARAMETER(IoStatus); + UNREFERENCED_PARAMETER(DeviceObject); BOOLEAN bStatus = FALSE; @@ -293,6 +387,10 @@ AFSFastIoMdlWriteComplete( IN struct _FILE_OBJECT *FileObject, IN PMDL MdlChain, IN struct _DEVICE_OBJECT *DeviceObject) { + UNREFERENCED_PARAMETER(FileObject); + UNREFERENCED_PARAMETER(FileOffset); + UNREFERENCED_PARAMETER(MdlChain); + UNREFERENCED_PARAMETER(DeviceObject); BOOLEAN bStatus = FALSE; @@ -305,6 +403,8 @@ AFSFastIoAcquireForModWrite( IN struct _FILE_OBJECT *FileObject, OUT struct _ERESOURCE **ResourceToRelease, IN struct _DEVICE_OBJECT *DeviceObject) { + UNREFERENCED_PARAMETER(DeviceObject); + UNREFERENCED_PARAMETER(EndingOffset); NTSTATUS ntStatus = STATUS_FILE_LOCK_CONFLICT; AFSFcb *pFcb = (AFSFcb *)FileObject->FsContext; @@ -336,6 +436,8 @@ AFSFastIoReleaseForModWrite( IN struct _FILE_OBJECT *FileObject, IN struct _ERESOURCE *ResourceToRelease, IN struct _DEVICE_OBJECT *DeviceObject) { + UNREFERENCED_PARAMETER(FileObject); + UNREFERENCED_PARAMETER(DeviceObject); NTSTATUS ntStatus = STATUS_SUCCESS; @@ -354,6 +456,7 @@ NTSTATUS AFSFastIoAcquireForCCFlush( IN struct _FILE_OBJECT *FileObject, IN struct _DEVICE_OBJECT *DeviceObject) { + UNREFERENCED_PARAMETER(DeviceObject); NTSTATUS ntStatus = STATUS_FILE_LOCK_CONFLICT; AFSFcb *pFcb = (AFSFcb *)FileObject->FsContext; @@ -411,6 +514,7 @@ NTSTATUS AFSFastIoReleaseForCCFlush( IN struct _FILE_OBJECT *FileObject, IN struct _DEVICE_OBJECT *DeviceObject) { + UNREFERENCED_PARAMETER(DeviceObject); NTSTATUS ntStatus = STATUS_SUCCESS; AFSFcb *pFcb = (AFSFcb *)FileObject->FsContext; @@ -463,6 +567,16 @@ AFSFastIoReadCompressed( IN struct _FILE_OBJECT *FileObject, IN ULONG CompressedDataInfoLength, IN struct _DEVICE_OBJECT *DeviceObject) { + UNREFERENCED_PARAMETER(FileObject); + UNREFERENCED_PARAMETER(FileOffset); + UNREFERENCED_PARAMETER(Length); + UNREFERENCED_PARAMETER(LockKey); + UNREFERENCED_PARAMETER(Buffer); + UNREFERENCED_PARAMETER(MdlChain); + UNREFERENCED_PARAMETER(IoStatus); + UNREFERENCED_PARAMETER(CompressedDataInfo); + UNREFERENCED_PARAMETER(CompressedDataInfoLength); + UNREFERENCED_PARAMETER(DeviceObject); BOOLEAN bStatus = FALSE; @@ -481,6 +595,16 @@ AFSFastIoWriteCompressed( IN struct _FILE_OBJECT *FileObject, IN ULONG CompressedDataInfoLength, IN struct _DEVICE_OBJECT *DeviceObject) { + UNREFERENCED_PARAMETER(FileObject); + UNREFERENCED_PARAMETER(FileOffset); + UNREFERENCED_PARAMETER(Length); + UNREFERENCED_PARAMETER(LockKey); + UNREFERENCED_PARAMETER(Buffer); + UNREFERENCED_PARAMETER(MdlChain); + UNREFERENCED_PARAMETER(IoStatus); + UNREFERENCED_PARAMETER(CompressedDataInfo); + UNREFERENCED_PARAMETER(CompressedDataInfoLength); + UNREFERENCED_PARAMETER(DeviceObject); BOOLEAN bStatus = FALSE; @@ -492,6 +616,9 @@ AFSFastIoMdlReadCompleteCompressed( IN struct _FILE_OBJECT *FileObject, IN PMDL MdlChain, IN struct _DEVICE_OBJECT *DeviceObject) { + UNREFERENCED_PARAMETER(FileObject); + UNREFERENCED_PARAMETER(MdlChain); + UNREFERENCED_PARAMETER(DeviceObject); BOOLEAN bStatus = FALSE; @@ -504,6 +631,10 @@ AFSFastIoMdlWriteCompleteCompressed( IN struct _FILE_OBJECT *FileObject, IN PMDL MdlChain, IN struct _DEVICE_OBJECT *DeviceObject) { + UNREFERENCED_PARAMETER(FileObject); + UNREFERENCED_PARAMETER(FileOffset); + UNREFERENCED_PARAMETER(MdlChain); + UNREFERENCED_PARAMETER(DeviceObject); BOOLEAN bStatus = FALSE; @@ -515,6 +646,9 @@ AFSFastIoQueryOpen( IN struct _IRP *Irp, OUT PFILE_NETWORK_OPEN_INFORMATION NetworkInformation, IN struct _DEVICE_OBJECT *DeviceObject) { + UNREFERENCED_PARAMETER(Irp); + UNREFERENCED_PARAMETER(NetworkInformation); + UNREFERENCED_PARAMETER(DeviceObject); BOOLEAN bStatus = FALSE; diff --git a/src/WINNT/afsrdr/kernel/fs/AFSFileInfo.cpp b/src/WINNT/afsrdr/kernel/fs/AFSFileInfo.cpp index 9d3d921f3..bc8742660 100644 --- a/src/WINNT/afsrdr/kernel/fs/AFSFileInfo.cpp +++ b/src/WINNT/afsrdr/kernel/fs/AFSFileInfo.cpp @@ -157,7 +157,6 @@ AFSSetFileInfo( IN PDEVICE_OBJECT DeviceObject, { NTSTATUS ntStatus = STATUS_SUCCESS; - AFSDeviceExt *pDeviceExt = (AFSDeviceExt *)DeviceObject->DeviceExtension; AFSDeviceExt *pControlDeviceExt = (AFSDeviceExt *)AFSDeviceObject->DeviceExtension; IO_STACK_LOCATION *pIrpSp = IoGetCurrentIrpStackLocation( Irp); AFSFcb* pFcb = NULL; diff --git a/src/WINNT/afsrdr/kernel/fs/AFSGeneric.cpp b/src/WINNT/afsrdr/kernel/fs/AFSGeneric.cpp index 7fed71c90..bc12bdbed 100644 --- a/src/WINNT/afsrdr/kernel/fs/AFSGeneric.cpp +++ b/src/WINNT/afsrdr/kernel/fs/AFSGeneric.cpp @@ -55,6 +55,7 @@ AFSExceptionFilter( IN CHAR *FunctionString, IN ULONG Code, IN PEXCEPTION_POINTERS ExceptPtrs) { + UNREFERENCED_PARAMETER(Code); PEXCEPTION_RECORD ExceptRec; PCONTEXT Context; @@ -609,7 +610,6 @@ AFSUpdateRegistryParameter( IN PUNICODE_STRING ValueName, NTSTATUS ntStatus = STATUS_SUCCESS; UNICODE_STRING paramPath, uniParamKey; HANDLE hParameters = 0; - ULONG ulDisposition = 0; OBJECT_ATTRIBUTES stObjectAttributes; __Enter @@ -700,7 +700,6 @@ AFSInitializeControlDevice() NTSTATUS ntStatus = STATUS_SUCCESS; AFSDeviceExt *pDeviceExt = (AFSDeviceExt *)AFSDeviceObject->DeviceExtension; - AFSProcessCB *pProcessCB = NULL; __Enter { @@ -820,7 +819,6 @@ AFSRemoveControlDevice() NTSTATUS ntStatus = STATUS_SUCCESS; AFSDeviceExt *pDeviceExt = (AFSDeviceExt *)AFSDeviceObject->DeviceExtension; - AFSProcessCB *pProcessCB = NULL; __Enter { @@ -909,7 +907,6 @@ AFSReadServerName() { NTSTATUS ntStatus = STATUS_SUCCESS; - ULONG Default = 0; UNICODE_STRING paramPath; RTL_QUERY_REGISTRY_TABLE paramTable[2]; @@ -1001,7 +998,6 @@ AFSReadMountRootName() { NTSTATUS ntStatus = STATUS_SUCCESS; - ULONG Default = 0; UNICODE_STRING paramPath; RTL_QUERY_REGISTRY_TABLE paramTable[2]; @@ -1101,6 +1097,7 @@ NTSTATUS AFSSetSysNameInformation( IN AFSSysNameNotificationCB *SysNameInfo, IN ULONG SysNameInfoBufferLength) { + UNREFERENCED_PARAMETER(SysNameInfoBufferLength); NTSTATUS ntStatus = STATUS_SUCCESS; AFSDeviceExt *pControlDevExt = (AFSDeviceExt *)AFSDeviceObject->DeviceExtension; @@ -1255,9 +1252,9 @@ NTSTATUS AFSDefaultDispatch( IN PDEVICE_OBJECT DeviceObject, IN PIRP Irp) { + UNREFERENCED_PARAMETER(DeviceObject); NTSTATUS ntStatus = STATUS_INVALID_DEVICE_REQUEST; - PIO_STACK_LOCATION pIrpSp = IoGetCurrentIrpStackLocation( Irp); AFSCompleteRequest( Irp, ntStatus); @@ -1274,6 +1271,8 @@ AFSSendDeviceIoControl( IN DEVICE_OBJECT *TargetDeviceObject, IN ULONG OutputBufferLength, OUT ULONG *ResultLength) { + UNREFERENCED_PARAMETER(OutputBuffer); + UNREFERENCED_PARAMETER(OutputBufferLength); NTSTATUS ntStatus = STATUS_SUCCESS; PIRP pIrp = NULL; @@ -1402,6 +1401,8 @@ AFSIrpComplete( IN PDEVICE_OBJECT DeviceObject, IN PIRP Irp, IN PVOID Context) { + UNREFERENCED_PARAMETER(DeviceObject); + UNREFERENCED_PARAMETER(Irp); KEVENT *pEvent = (KEVENT *)Context; @@ -1898,6 +1899,7 @@ try_exit: ULONG AFSGetSessionId( IN HANDLE ProcessId, OUT BOOLEAN *pbImpersonation) { + UNREFERENCED_PARAMETER(ProcessId); NTSTATUS ntStatus = STATUS_SUCCESS; PACCESS_TOKEN hToken = NULL; diff --git a/src/WINNT/afsrdr/kernel/fs/AFSInit.cpp b/src/WINNT/afsrdr/kernel/fs/AFSInit.cpp index 8ff1be2f0..1969d4f45 100644 --- a/src/WINNT/afsrdr/kernel/fs/AFSInit.cpp +++ b/src/WINNT/afsrdr/kernel/fs/AFSInit.cpp @@ -68,8 +68,7 @@ DriverEntry( PDRIVER_OBJECT DriverObject, { NTSTATUS ntStatus = STATUS_SUCCESS; - AFSDeviceExt *pDeviceExt; - ULONG ulTimeIncrement = 0; + AFSDeviceExt *pDeviceExt = NULL; UNICODE_STRING uniSymLinkName; UNICODE_STRING uniDeviceName; ULONG ulIndex = 0; diff --git a/src/WINNT/afsrdr/kernel/fs/AFSInternalDevControl.cpp b/src/WINNT/afsrdr/kernel/fs/AFSInternalDevControl.cpp index d966f2560..371f66045 100644 --- a/src/WINNT/afsrdr/kernel/fs/AFSInternalDevControl.cpp +++ b/src/WINNT/afsrdr/kernel/fs/AFSInternalDevControl.cpp @@ -42,6 +42,7 @@ NTSTATUS AFSInternalDevControl( IN PDEVICE_OBJECT DeviceObject, IN PIRP Irp) { + UNREFERENCED_PARAMETER(DeviceObject); NTSTATUS ntStatus = STATUS_NOT_IMPLEMENTED; IO_STACK_LOCATION *pIrpSp; diff --git a/src/WINNT/afsrdr/kernel/fs/AFSLibrarySupport.cpp b/src/WINNT/afsrdr/kernel/fs/AFSLibrarySupport.cpp index 2186bc19d..5de9bc925 100644 --- a/src/WINNT/afsrdr/kernel/fs/AFSLibrarySupport.cpp +++ b/src/WINNT/afsrdr/kernel/fs/AFSLibrarySupport.cpp @@ -42,6 +42,7 @@ NTSTATUS AFSLoadLibrary( IN ULONG Flags, IN UNICODE_STRING *ServicePath) { + UNREFERENCED_PARAMETER(Flags); NTSTATUS ntStatus = STATUS_SUCCESS; AFSDeviceExt *pDevExt = (AFSDeviceExt *)AFSDeviceObject->DeviceExtension; @@ -848,6 +849,7 @@ NTSTATUS AFSInitializeLibrary( IN AFSFileID *GlobalRootFid, IN BOOLEAN QueueRootEnumeration) { + UNREFERENCED_PARAMETER(QueueRootEnumeration); NTSTATUS ntStatus = STATUS_SUCCESS; AFSLibraryInitCB stInitLib; diff --git a/src/WINNT/afsrdr/kernel/fs/AFSProcessSupport.cpp b/src/WINNT/afsrdr/kernel/fs/AFSProcessSupport.cpp index 35326b253..22cf280ab 100644 --- a/src/WINNT/afsrdr/kernel/fs/AFSProcessSupport.cpp +++ b/src/WINNT/afsrdr/kernel/fs/AFSProcessSupport.cpp @@ -71,6 +71,7 @@ AFSProcessNotifyEx( IN OUT PEPROCESS Process, IN HANDLE ProcessId, IN OUT PPS_CREATE_NOTIFY_INFO CreateInfo) { + UNREFERENCED_PARAMETER(Process); if ( CreateInfo) { @@ -94,7 +95,6 @@ AFSProcessCreate( IN HANDLE ParentId, IN HANDLE CreatingProcessId, IN HANDLE CreatingThreadId) { - NTSTATUS ntStatus = STATUS_SUCCESS; AFSDeviceExt *pDeviceExt = (AFSDeviceExt *)AFSDeviceObject->DeviceExtension; AFSProcessCB *pProcessCB = NULL; @@ -157,7 +157,7 @@ AFSProcessDestroy( IN HANDLE ProcessId) NTSTATUS ntStatus = STATUS_SUCCESS; AFSDeviceExt *pDeviceExt = (AFSDeviceExt *)AFSDeviceObject->DeviceExtension; - AFSProcessCB *pProcessCB = NULL, *pParentProcessCB = NULL; + AFSProcessCB *pProcessCB = NULL; AFSProcessAuthGroupCB *pProcessAuthGroup = NULL, *pLastAuthGroup = NULL; AFSThreadCB *pThreadCB = NULL, *pNextThreadCB = NULL; diff --git a/src/WINNT/afsrdr/kernel/fs/AFSQuota.cpp b/src/WINNT/afsrdr/kernel/fs/AFSQuota.cpp index 7d139c50f..bdbd5a68c 100644 --- a/src/WINNT/afsrdr/kernel/fs/AFSQuota.cpp +++ b/src/WINNT/afsrdr/kernel/fs/AFSQuota.cpp @@ -42,6 +42,7 @@ NTSTATUS AFSQueryQuota( IN PDEVICE_OBJECT DeviceObject, IN PIRP Irp) { + UNREFERENCED_PARAMETER(DeviceObject); NTSTATUS ntStatus = STATUS_NOT_SUPPORTED; IO_STACK_LOCATION *pIrpSp; @@ -77,6 +78,7 @@ NTSTATUS AFSSetQuota( IN PDEVICE_OBJECT DeviceObject, IN PIRP Irp) { + UNREFERENCED_PARAMETER(DeviceObject); NTSTATUS ntStatus = STATUS_NOT_SUPPORTED; IO_STACK_LOCATION *pIrpSp; diff --git a/src/WINNT/afsrdr/kernel/fs/AFSRDRSupport.cpp b/src/WINNT/afsrdr/kernel/fs/AFSRDRSupport.cpp index 12b899d8f..544387564 100644 --- a/src/WINNT/afsrdr/kernel/fs/AFSRDRSupport.cpp +++ b/src/WINNT/afsrdr/kernel/fs/AFSRDRSupport.cpp @@ -45,9 +45,7 @@ AFSInitRDRDevice() NTSTATUS ntStatus = STATUS_SUCCESS; UNICODE_STRING uniDeviceName; - ULONG ulIndex = 0; AFSDeviceExt *pDeviceExt = NULL; - AFSFileID stRootFid; UNICODE_STRING uniFsRtlRegisterUncProviderEx; FsRtlRegisterUncProviderEx_t pFsRtlRegisterUncProviderEx = NULL; @@ -209,10 +207,10 @@ NTSTATUS AFSRDRDeviceControl( IN PDEVICE_OBJECT DeviceObject, IN PIRP Irp) { + UNREFERENCED_PARAMETER(DeviceObject); NTSTATUS ntStatus = STATUS_SUCCESS; PIO_STACK_LOCATION pIrpSp = IoGetCurrentIrpStackLocation( Irp); - PFILE_OBJECT pFileObject = pIrpSp->FileObject; BOOLEAN bCompleteIrp = TRUE; __Enter @@ -347,7 +345,6 @@ AFSInitializeRedirector( IN AFSRedirectorInitInfo *RedirInitInfo) NTSTATUS ntStatus = STATUS_SUCCESS; LARGE_INTEGER cacheSizeBytes; AFSDeviceExt *pDevExt = (AFSDeviceExt *)AFSRDRDeviceObject->DeviceExtension; - AFSDeviceExt *pControlDevExt = (AFSDeviceExt *)AFSDeviceObject->DeviceExtension; OBJECT_ATTRIBUTES stObjectAttribs; IO_STATUS_BLOCK stIoStatus; UNICODE_STRING uniServiceName; @@ -849,8 +846,6 @@ AFSInitRdrFcb( OUT AFSFcb **RdrFcb) NTSTATUS ntStatus = STATUS_SUCCESS; AFSFcb *pFcb = NULL; AFSNonPagedFcb *pNPFcb = NULL; - IO_STATUS_BLOCK stIoStatus = {0,0}; - AFSDeviceExt *pDeviceExt = (AFSDeviceExt *)AFSRDRDeviceObject->DeviceExtension; __Enter { diff --git a/src/WINNT/afsrdr/kernel/fs/AFSShutdown.cpp b/src/WINNT/afsrdr/kernel/fs/AFSShutdown.cpp index 5e6fd9e77..073aed18a 100644 --- a/src/WINNT/afsrdr/kernel/fs/AFSShutdown.cpp +++ b/src/WINNT/afsrdr/kernel/fs/AFSShutdown.cpp @@ -42,6 +42,7 @@ NTSTATUS AFSShutdown( IN PDEVICE_OBJECT DeviceObject, IN PIRP Irp) { + UNREFERENCED_PARAMETER(DeviceObject); NTSTATUS ntStatus = STATUS_SUCCESS; IO_STACK_LOCATION *pIrpSp; diff --git a/src/WINNT/afsrdr/kernel/fs/AFSSystemControl.cpp b/src/WINNT/afsrdr/kernel/fs/AFSSystemControl.cpp index 63817f3e9..51443f08d 100644 --- a/src/WINNT/afsrdr/kernel/fs/AFSSystemControl.cpp +++ b/src/WINNT/afsrdr/kernel/fs/AFSSystemControl.cpp @@ -42,6 +42,7 @@ NTSTATUS AFSSystemControl( IN PDEVICE_OBJECT DeviceObject, IN PIRP Irp) { + UNREFERENCED_PARAMETER(DeviceObject); NTSTATUS ntStatus = STATUS_NOT_IMPLEMENTED; IO_STACK_LOCATION *pIrpSp; diff --git a/src/WINNT/afsrdr/kernel/fs/AFSVolumeInfo.cpp b/src/WINNT/afsrdr/kernel/fs/AFSVolumeInfo.cpp index 485713d3c..e92c04d34 100644 --- a/src/WINNT/afsrdr/kernel/fs/AFSVolumeInfo.cpp +++ b/src/WINNT/afsrdr/kernel/fs/AFSVolumeInfo.cpp @@ -44,7 +44,6 @@ AFSQueryVolumeInfo( IN PDEVICE_OBJECT DeviceObject, { NTSTATUS ntStatus = STATUS_SUCCESS; - AFSDeviceExt *pDeviceExt = (AFSDeviceExt *)DeviceObject->DeviceExtension; IO_STACK_LOCATION *pIrpSp; AFSDeviceExt *pControlDeviceExt = (AFSDeviceExt *)AFSDeviceObject->DeviceExtension; @@ -114,6 +113,7 @@ NTSTATUS AFSSetVolumeInfo( IN PDEVICE_OBJECT DeviceObject, IN PIRP Irp) { + UNREFERENCED_PARAMETER(DeviceObject); NTSTATUS ntStatus = STATUS_INVALID_DEVICE_REQUEST; IO_STACK_LOCATION *pIrpSp; -- 2.39.5