From 9865698ee0d81d371b8846a1145a46f691de8388 Mon Sep 17 00:00:00 2001 From: Derrick Brashear Date: Sun, 6 Nov 2011 16:28:27 -0500 Subject: [PATCH] dafs: avoid null deref getting volume header we don't assign hd before dereferencing. stop dereferencing and just use the queue cursor. Reviewed-on: http://gerrit.openafs.org/5814 Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: Derrick Brashear (cherry picked from commit 00beae8c4e3b390637f20584e676cf86c817dadd) Change-Id: Iec2dbbf84e4f08f02998c9e998d2ea899ce48a5d Reviewed-on: http://gerrit.openafs.org/6122 Tested-by: BuildBot Reviewed-by: Derrick Brashear --- src/vol/volume.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vol/volume.c b/src/vol/volume.c index 64647ade1..c7cca3f10 100644 --- a/src/vol/volume.c +++ b/src/vol/volume.c @@ -7481,7 +7481,7 @@ GetVolHeaderFromLRU(void) * could VWaitExclusiveState_r instead, but not waiting is faster and * easier to do */ for (queue_Scan(&volume_hdr_LRU, qh, nqh, volHeader)) { - if (!hd->back || !VIsExclusiveState(V_attachState(hd->back))) { + if (!qh->back || !VIsExclusiveState(V_attachState(qh->back))) { queue_Remove(qh); hd = qh; break; -- 2.39.5