From 9b3f4d8be8b7b9c7760abf982b9ed12bc457b66e Mon Sep 17 00:00:00 2001 From: Simon Wilkinson Date: Tue, 19 Feb 2013 15:43:29 +0000 Subject: [PATCH] ptserver: Don't ignore ubik_Write failures If we can't write to the ubik database, then that's a bad thing. Don't ignore it. Caught by clang-analyzer Reviewed-on: http://gerrit.openafs.org/9176 Tested-by: BuildBot Reviewed-by: Jeffrey Altman Reviewed-by: Derrick Brashear (cherry picked from commit 860c34ba938602387f78c10c2f548fb8a523a9cd) Change-Id: Id379d94844e6cc520829b4ef6015d0a004fdbc42 Reviewed-on: http://gerrit.openafs.org/9526 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand --- src/ptserver/ptutils.c | 2 ++ src/ptserver/utils.c | 4 ++++ 2 files changed, 6 insertions(+) diff --git a/src/ptserver/ptutils.c b/src/ptserver/ptutils.c index d2548dbc9..9d764fcd5 100644 --- a/src/ptserver/ptutils.c +++ b/src/ptserver/ptutils.c @@ -457,6 +457,8 @@ CreateEntry(struct ubik_trans *at, char aname[PR_MAXNAMELEN], afs_int32 *aid, af /* write updated entry for group */ code = pr_Write(at, 0, pos, ¢ry, sizeof(centry)); + if (code) + return PRDBFAIL; /* Now add the new user entry to the database */ tentry.creator = creator; diff --git a/src/ptserver/utils.c b/src/ptserver/utils.c index 230e76041..822df9948 100644 --- a/src/ptserver/utils.c +++ b/src/ptserver/utils.c @@ -488,6 +488,8 @@ RemoveFromIDHash(struct ubik_trans *tt, afs_int32 aid, afs_int32 *loc) /* ??? i return PRDBFAIL; bentry.nextID = tentry.nextID; code = pr_WriteEntry(tt, 0, trail, &bentry); + if (code) + return PRDBFAIL; } *loc = current; return PRSUCCESS; @@ -566,6 +568,8 @@ RemoveFromNameHash(struct ubik_trans *tt, char *aname, afs_int32 *loc) return PRDBFAIL; bentry.nextName = tentry.nextName; code = pr_WriteEntry(tt, 0, trail, &bentry); + if (code) + return PRDBFAIL; } *loc = current; return PRSUCCESS; -- 2.39.5