From 9baec50e7bfa0d900bc33d91a277f24e72889e40 Mon Sep 17 00:00:00 2001 From: Simon Wilkinson Date: Sat, 12 Jun 2010 10:42:43 +0100 Subject: [PATCH] libadmin: Don't dereference NULL pointer in cmd If DoBosHostList ends up being called without the -server argument in its command structure, then a printf will attempt to dereference a NULL pointer to the -server field. Caught by clang-analyzer Change-Id: I1114406d03b265f4d780efd8e84fea53013cb51c Reviewed-on: http://gerrit.openafs.org/2143 Reviewed-by: Russ Allbery Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear --- src/libadmin/test/bos.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/libadmin/test/bos.c b/src/libadmin/test/bos.c index 3b283b371..3661d2cc4 100644 --- a/src/libadmin/test/bos.c +++ b/src/libadmin/test/bos.c @@ -1270,13 +1270,14 @@ DoBosHostList(struct cmd_syndesc *as, void *arock) (cellHandle, as->parms[SERVER].items->data, &bos_server, &st)) { ERR_ST_EXT("bos_ServerOpen", st); } + + printf("Listing hosts at server %s\n", as->parms[SERVER].items->data); } if (!bos_HostGetBegin(bos_server, &iter, &st)) { ERR_ST_EXT("bos_HostGetBegin", st); } - printf("Listing hosts at server %s\n", as->parms[SERVER].items->data); while (bos_HostGetNext(iter, host, &st)) { printf("\t%s\n", host); -- 2.39.5