From a329e9a9d859fb99d6ed2d0143b5b55ef6b66106 Mon Sep 17 00:00:00 2001
From: Simon Wilkinson <sxw@your-file-system.com>
Date: Sun, 27 Mar 2011 22:18:23 +0100
Subject: [PATCH] rx: Tidy header includes

Remove headers which are provided by libroken, and reorder header
includes so that they're a bit a more legible.

Change-Id: I7bb08d7ec7a75b485f7f619fd4d8179d4c7349f0
Reviewed-on: http://gerrit.openafs.org/4403
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
---
 src/rx/rx.c           | 20 +++-----------------
 src/rx/rx_clock.c     | 10 ++--------
 src/rx/rx_clock_nt.c  |  3 +--
 src/rx/rx_conncache.c |  6 +-----
 src/rx/rx_event.c     |  6 +-----
 src/rx/rx_getaddr.c   | 11 +++--------
 src/rx/rx_globals.c   |  2 +-
 src/rx/rx_identity.c  |  2 --
 src/rx/rx_kcommon.c   |  2 +-
 src/rx/rx_lwp.c       | 26 ++------------------------
 src/rx/rx_misc.c      | 12 ------------
 src/rx/rx_multi.c     |  2 +-
 src/rx/rx_null.c      |  2 +-
 src/rx/rx_opaque.c    |  3 ---
 src/rx/rx_packet.c    | 12 ------------
 src/rx/rx_pthread.c   | 26 +++-----------------------
 src/rx/rx_rdwr.c      | 13 -------------
 src/rx/rx_stats.c     |  1 -
 src/rx/rx_trace.c     | 12 +-----------
 src/rx/rx_user.c      | 23 ++---------------------
 src/rx/xdr.c          |  3 ---
 src/rx/xdr_afsuuid.c  |  9 ++-------
 src/rx/xdr_array.c    |  6 ------
 src/rx/xdr_arrayn.c   |  6 +-----
 src/rx/xdr_int32.c    |  6 +-----
 src/rx/xdr_int64.c    |  2 +-
 src/rx/xdr_len.c      |  2 +-
 src/rx/xdr_mem.c      |  5 +----
 src/rx/xdr_rec.c      | 13 +------------
 src/rx/xdr_rx.c       |  5 -----
 30 files changed, 31 insertions(+), 220 deletions(-)

diff --git a/src/rx/rx.c b/src/rx/rx.c
index 6c8071544..f7f6d7955 100644
--- a/src/rx/rx.c
+++ b/src/rx/rx.c
@@ -10,7 +10,7 @@
 /* RX:  Extended Remote Procedure Call */
 
 #include <afsconfig.h>
-#include "afs/param.h"
+#include <afs/param.h>
 
 #ifdef KERNEL
 # include "afs/sysincludes.h"
@@ -63,26 +63,12 @@ extern afs_int32 afs_termState;
 # include "afs/rxgen_consts.h"
 #else /* KERNEL */
 # include <roken.h>
-# include <sys/types.h>
-# include <string.h>
-# include <stdarg.h>
-# include <errno.h>
-# ifdef HAVE_STDINT_H
-#  include <stdint.h>
-# endif
+
 # ifdef AFS_NT40_ENV
-#  include <stdlib.h>
-#  include <fcntl.h>
 #  include <afs/afsutil.h>
 #  include <WINNT\afsreg.h>
-# else
-#  include <sys/socket.h>
-#  include <sys/file.h>
-#  include <netdb.h>
-#  include <sys/stat.h>
-#  include <netinet/in.h>
-#  include <sys/time.h>
 # endif
+
 # include "rx_user.h"
 #endif /* KERNEL */
 
diff --git a/src/rx/rx_clock.c b/src/rx/rx_clock.c
index 38e726bcf..057e1c4b4 100644
--- a/src/rx/rx_clock.c
+++ b/src/rx/rx_clock.c
@@ -11,7 +11,7 @@
 /* See rx_clock.h for calling conventions */
 
 #include <afsconfig.h>
-#include "afs/param.h"
+#include <afs/param.h>
 
 #ifdef AFS_SUN59_ENV
 #include <sys/time_impl.h>
@@ -26,13 +26,7 @@
 #  include "afsincludes.h"
 # endif /* !UKERNEL */
 #else /* KERNEL */
-# include <sys/time.h>
-# ifdef HAVE_SIGNAL_H
-#  include <signal.h>
-# endif
-# include <stdio.h>
-# include <errno.h>
-# include <stdlib.h>
+# include <roken.h>
 #endif
 
 #include "rx.h"
diff --git a/src/rx/rx_clock_nt.c b/src/rx/rx_clock_nt.c
index 1a371e76f..72bc76e0b 100644
--- a/src/rx/rx_clock_nt.c
+++ b/src/rx/rx_clock_nt.c
@@ -13,10 +13,9 @@
 #include <afsconfig.h>
 #include <afs/param.h>
 
+#include <roken.h>
 
 #ifdef AFS_NT40_ENV
-#include <stdio.h>
-#include <stdlib.h>
 #include <windef.h>
 #include <winbase.h>
 #include "rx_clock.h"
diff --git a/src/rx/rx_conncache.c b/src/rx/rx_conncache.c
index 670cda127..1202f5837 100644
--- a/src/rx/rx_conncache.c
+++ b/src/rx/rx_conncache.c
@@ -14,12 +14,8 @@
 #include <afsconfig.h>
 #include <afs/param.h>
 
-#ifndef KERNEL
-# include <roken.h>
-#endif /* KERNEL */
+#include <roken.h>
 
-#include <sys/types.h>
-#include <errno.h>
 #include "rx.h"
 
 /*
diff --git a/src/rx/rx_event.c b/src/rx/rx_event.c
index f822419a1..b520f1657 100644
--- a/src/rx/rx_event.c
+++ b/src/rx/rx_event.c
@@ -8,7 +8,7 @@
  */
 
 #include <afsconfig.h>
-#include "afs/param.h"
+#include <afs/param.h>
 
 #ifdef AFS_SUN59_ENV
 # include <sys/time_impl.h>
@@ -41,16 +41,12 @@ extern void *osi_Alloc();
 # endif
 #else /* KERNEL */
 # include <roken.h>
-# include <stdio.h>
 # include "rx_user.h"
 # ifdef AFS_PTHREAD_ENV
 #  include "rx_pthread.h"
 # else
 #  include "rx_lwp.h"
 # endif
-# ifdef AFS_NT40_ENV
-#  include <malloc.h>
-# endif
 #endif /* KERNEL */
 
 #include "rx.h"
diff --git a/src/rx/rx_getaddr.c b/src/rx/rx_getaddr.c
index 55f3e35bd..0c7d3aed9 100644
--- a/src/rx/rx_getaddr.c
+++ b/src/rx/rx_getaddr.c
@@ -10,16 +10,11 @@
 #include <afsconfig.h>
 #include <afs/param.h>
 
-
 #ifndef KERNEL
+
+# include <roken.h>
 # ifndef AFS_NT40_ENV
-#  include <sys/types.h>
-#  include <sys/socket.h>
-#  include <sys/time.h>
-#  include <net/if.h>
-#  include <netinet/in.h>
-#  include <sys/ioctl.h>
-#  include <string.h>
+# include <net/if.h>
 #  if defined(AFS_DARWIN_ENV) || defined(AFS_XBSD_ENV)
 #   include <sys/sysctl.h>
 #   ifndef AFS_ARM_DARWIN_ENV
diff --git a/src/rx/rx_globals.c b/src/rx/rx_globals.c
index bc029a8df..cfaaa0419 100644
--- a/src/rx/rx_globals.c
+++ b/src/rx/rx_globals.c
@@ -19,7 +19,7 @@
 #endif
 
 #include <afsconfig.h>
-#include "afs/param.h"
+#include <afs/param.h>
 
 /* Enable data initialization when the header file is included */
 #define GLOBALSINIT(stuff) = stuff
diff --git a/src/rx/rx_identity.c b/src/rx/rx_identity.c
index 514d97be5..ae9c694d1 100644
--- a/src/rx/rx_identity.c
+++ b/src/rx/rx_identity.c
@@ -27,8 +27,6 @@
 
 #ifndef KERNEL
 # include <roken.h>
-# include <sys/types.h>
-# include <string.h>
 #else
 # include "afs/sysincludes.h"
 # include "afsincludes.h"
diff --git a/src/rx/rx_kcommon.c b/src/rx/rx_kcommon.c
index b04429f96..a7c97596b 100644
--- a/src/rx/rx_kcommon.c
+++ b/src/rx/rx_kcommon.c
@@ -12,7 +12,7 @@
  */
 
 #include <afsconfig.h>
-#include "afs/param.h"
+#include <afs/param.h>
 
 
 #include "rx/rx_kcommon.h"
diff --git a/src/rx/rx_lwp.c b/src/rx/rx_lwp.c
index 8ad021bf8..1de085731 100644
--- a/src/rx/rx_lwp.c
+++ b/src/rx/rx_lwp.c
@@ -21,36 +21,14 @@
 #include <afsconfig.h>
 #include <afs/param.h>
 
-#ifndef KERNEL
-# include <roken.h>
-#endif /* KERNEL */
+#include <roken.h>
 
-#include <sys/types.h>		/* fd_set on older platforms */
-#include <errno.h>
-#include <signal.h>
-#ifdef AFS_NT40_ENV
-# include <winsock2.h>
-#else
-# include <unistd.h>		/* select() prototype */
-# include <sys/time.h>		/* struct timeval, select() prototype */
-# ifndef FD_SET
-#  include <sys/select.h>	/* fd_set on newer platforms */
-# endif
-# include <sys/socket.h>
-# include <sys/file.h>
-# include <netdb.h>
-# include <sys/stat.h>
-# include <netinet/in.h>
-# include <net/if.h>
-# include <sys/ioctl.h>
-# include <sys/time.h>
-#endif
+#include <lwp.h>
 
 #include "rx.h"
 #include "rx_atomic.h"
 #include "rx_globals.h"
 #include "rx_stats.h"
-#include <lwp.h>
 
 #define MAXTHREADNAMELENGTH 64
 
diff --git a/src/rx/rx_misc.c b/src/rx/rx_misc.c
index 1d39f4ebb..c01b85708 100644
--- a/src/rx/rx_misc.c
+++ b/src/rx/rx_misc.c
@@ -15,23 +15,11 @@
 # include <afsincludes.h>
 #else
 # include <roken.h>
-# ifdef AFS_NT40_ENV
-#  include <winsock2.h>
-#  include <malloc.h>
-# else
-#  include <sys/param.h>
-# endif
-# include <errno.h>
 # include <afs/errors.h>
 # include "xdr.h"
 # ifdef AFS_PTHREAD_ENV
 #  include "rx.h"
 # endif /* AFS_PTHREAD_ENV */
-# include <stdlib.h>
-# include <string.h>
-# ifdef HAVE_UNISTD_H
-#  include <unistd.h>
-# endif
 # ifdef AFS_NT40_ENV
 #  ifndef EDQUOT
 #   define EDQUOT WSAEDQUOT
diff --git a/src/rx/rx_multi.c b/src/rx/rx_multi.c
index c6af54a6d..cefa0a28a 100644
--- a/src/rx/rx_multi.c
+++ b/src/rx/rx_multi.c
@@ -11,7 +11,7 @@
 #include <afs/param.h>
 
 #ifdef	KERNEL
-#include "afs/sysincludes.h"
+# include "afs/sysincludes.h"
 #else /* KERNEL */
 # include <roken.h>
 #endif /* KERNEL */
diff --git a/src/rx/rx_null.c b/src/rx/rx_null.c
index 231e7ae48..809fc67b4 100644
--- a/src/rx/rx_null.c
+++ b/src/rx/rx_null.c
@@ -8,7 +8,7 @@
  */
 
 #include <afsconfig.h>
-#include "afs/param.h"
+#include <afs/param.h>
 
 #ifdef KERNEL
 # ifndef UKERNEL
diff --git a/src/rx/rx_opaque.c b/src/rx/rx_opaque.c
index a1b61d580..db3e40706 100644
--- a/src/rx/rx_opaque.c
+++ b/src/rx/rx_opaque.c
@@ -27,9 +27,6 @@
 
 #ifndef KERNEL
 # include <roken.h>
-# include <sys/types.h>
-# include <string.h>
-# include <errno.h>
 #else
 # include "afs/sysincludes.h"
 # include "afsincludes.h"
diff --git a/src/rx/rx_packet.c b/src/rx/rx_packet.c
index a518bb152..138ca5351 100644
--- a/src/rx/rx_packet.c
+++ b/src/rx/rx_packet.c
@@ -42,25 +42,13 @@
 # endif /* defined(UKERNEL) */
 #else /* KERNEL */
 # include <roken.h>
-# include <sys/types.h>
-# include <sys/stat.h>
-# include <errno.h>
-# include <stdlib.h>
 # include <assert.h>
-# include <string.h>
-# ifdef HAVE_UNISTD_H
-#  include <unistd.h>
-# endif
 # if defined(AFS_NT40_ENV)
-#  include <winsock2.h>
 #  ifndef EWOULDBLOCK
 #   define EWOULDBLOCK WSAEWOULDBLOCK
 #  endif
 #  include "rx_user.h"
 #  include "rx_xmit_nt.h"
-# else
-#  include <sys/socket.h>
-#  include <netinet/in.h>
 # endif
 # include <lwp.h>
 #endif /* KERNEL */
diff --git a/src/rx/rx_pthread.c b/src/rx/rx_pthread.c
index 9c3edac3c..87a2c05d3 100644
--- a/src/rx/rx_pthread.c
+++ b/src/rx/rx_pthread.c
@@ -18,29 +18,9 @@
 #include <afsconfig.h>
 #include <afs/param.h>
 
-#ifndef KERNEL
-# include <roken.h>
-#endif /* KERNEL */
-
-#include <sys/types.h>
-#include <errno.h>
-#include <signal.h>
-#include <string.h>
-#ifdef HAVE_STDINT_H
-# include <stdint.h>
-#endif
-#ifndef AFS_NT40_ENV
-# include <sys/socket.h>
-# include <sys/file.h>
-# include <netdb.h>
-# include <netinet/in.h>
-# include <net/if.h>
-# include <sys/ioctl.h>
-# include <sys/time.h>
-# include <unistd.h>
-# include <assert.h>
-#endif
-#include <sys/stat.h>
+#include <roken.h>
+
+#include <assert.h>
 
 #include "rx.h"
 #include "rx_globals.h"
diff --git a/src/rx/rx_rdwr.c b/src/rx/rx_rdwr.c
index 53121e8af..61025eeb8 100644
--- a/src/rx/rx_rdwr.c
+++ b/src/rx/rx_rdwr.c
@@ -53,19 +53,6 @@
 # include "afs/lock.h"
 #else /* KERNEL */
 # include <roken.h>
-# include <sys/types.h>
-# include <string.h>
-# ifdef AFS_NT40_ENV
-#  include <winsock2.h>
-# else /* !AFS_NT40_ENV */
-#  include <sys/socket.h>
-#  include <sys/file.h>
-#  include <netdb.h>
-#  include <netinet/in.h>
-#  include <sys/stat.h>
-#  include <sys/time.h>
-#  include <unistd.h>
-# endif /* !AFS_NT40_ENV */
 #endif /* KERNEL */
 
 #include "rx.h"
diff --git a/src/rx/rx_stats.c b/src/rx/rx_stats.c
index 13935f368..d6325e1b8 100644
--- a/src/rx/rx_stats.c
+++ b/src/rx/rx_stats.c
@@ -33,7 +33,6 @@
 
 #if !defined(KERNEL)
 #include <roken.h>
-#include <string.h>
 #endif
 
 #ifdef KERNEL
diff --git a/src/rx/rx_trace.c b/src/rx/rx_trace.c
index eee07a47a..ded472211 100644
--- a/src/rx/rx_trace.c
+++ b/src/rx/rx_trace.c
@@ -10,9 +10,7 @@
 #include <afsconfig.h>
 #include <afs/param.h>
 
-#ifndef KERNEL
-# include <roken.h>
-#endif /* KERNEL */
+#include <roken.h>
 
 #ifndef RXDEBUG
 char rxi_tracename[80] = "\0Tracing not compiled in";
@@ -24,14 +22,6 @@ main(int argc, char **argv)
 }
 #endif
 #else
-#include <string.h>
-#ifdef AFS_NT40_ENV
-#include <fcntl.h>
-#include <io.h>
-#else
-#include <sys/file.h>
-#include <unistd.h>
-#endif
 
 #include "rx.h"
 #include "rx_atomic.h"
diff --git a/src/rx/rx_user.c b/src/rx/rx_user.c
index e9a836336..e4b59bba5 100644
--- a/src/rx/rx_user.c
+++ b/src/rx/rx_user.c
@@ -14,28 +14,13 @@
 #include <afsconfig.h>
 #include <afs/param.h>
 
-#ifndef KERNEL
-# include <roken.h>
-#endif /* KERNEL */
-
-#include <sys/types.h>
-#include <errno.h>
-#include <signal.h>
-#include <string.h>
+#include <roken.h>
+
 #ifdef AFS_NT40_ENV
 # include <WINNT/syscfg.h>
 #else
-# include <sys/socket.h>
-# include <sys/file.h>
-# include <netdb.h>
-# include <sys/stat.h>
-# include <netinet/in.h>
-# include <sys/time.h>
 # include <net/if.h>
-# include <sys/ioctl.h>
-# include <unistd.h>
 #endif
-#include <fcntl.h>
 #if !defined(AFS_AIX_ENV) && !defined(AFS_NT40_ENV)
 # include <sys/syscall.h>
 #endif
@@ -57,10 +42,6 @@
 #endif
 #endif
 
-#ifndef AFS_NT40_ENV
-# include <sys/time.h>
-#endif
-
 #include "rx.h"
 #include "rx_atomic.h"
 #include "rx_globals.h"
diff --git a/src/rx/xdr.c b/src/rx/xdr.c
index bb088e641..884627e4b 100644
--- a/src/rx/xdr.c
+++ b/src/rx/xdr.c
@@ -32,7 +32,6 @@
 
 #ifndef KERNEL
 # include <roken.h>
-# include <string.h>
 #endif
 
 
@@ -53,8 +52,6 @@
 #ifndef AFS_LINUX20_ENV
 #include <sys/systm.h>
 #endif
-#else
-#include <stdio.h>
 #endif
 #include "xdr.h"
 #include "rx.h"
diff --git a/src/rx/xdr_afsuuid.c b/src/rx/xdr_afsuuid.c
index f32c71dd0..da7855a1f 100644
--- a/src/rx/xdr_afsuuid.c
+++ b/src/rx/xdr_afsuuid.c
@@ -12,21 +12,16 @@
  */
 
 #include <afsconfig.h>
-#include "afs/param.h"
-
+#include <afs/param.h>
 
 #if defined(KERNEL) && !defined(UKERNEL)
 #ifdef AFS_LINUX20_ENV
 #include "h/string.h"
-#if 0
-#define bzero(A, C) memset((A), 0, (C))
-#endif
 #else
 #include <sys/param.h>
 #include <sys/systm.h>
 #endif
-#else
-#include <stdio.h>
+#include <roken.h>
 #endif
 #include "xdr.h"
 
diff --git a/src/rx/xdr_array.c b/src/rx/xdr_array.c
index 8f8ddc942..14378ebb9 100644
--- a/src/rx/xdr_array.c
+++ b/src/rx/xdr_array.c
@@ -51,17 +51,11 @@
 #include <sys/param.h>
 #ifdef AFS_LINUX20_ENV
 #include "h/string.h"
-#if 0
-#define bzero(A,C) memset((A), 0, (C))
-#endif
 #else
 #ifndef AFS_DARWIN90_ENV
 #include <sys/systm.h>
 #endif
 #endif /* AFS_LINUX20_ENV */
-#else
-#include <stdio.h>
-#include <string.h>
 #endif
 #include "xdr.h"
 
diff --git a/src/rx/xdr_arrayn.c b/src/rx/xdr_arrayn.c
index 28db31508..a7301d364 100644
--- a/src/rx/xdr_arrayn.c
+++ b/src/rx/xdr_arrayn.c
@@ -51,15 +51,11 @@
 #include <sys/param.h>
 #ifdef AFS_LINUX20_ENV
 #include "h/string.h"
-#if 0
-#define bzero(A,C) memset((A), 0, (C))
-#endif
 #else
 #include <sys/systm.h>
 #endif
 #else
-#include <stdio.h>
-#include <string.h>
+#include <roken.h>
 #endif
 #include "xdr.h"
 
diff --git a/src/rx/xdr_int32.c b/src/rx/xdr_int32.c
index 82c5648c8..c30b4e2d9 100644
--- a/src/rx/xdr_int32.c
+++ b/src/rx/xdr_int32.c
@@ -28,11 +28,7 @@
  */
 
 #include <afsconfig.h>
-#ifdef KERNEL
-#include "afs/param.h"
-#else
 #include <afs/param.h>
-#endif
 
 
 #ifndef	NeXT
@@ -40,7 +36,7 @@
 #if defined(KERNEL) && !defined(UKERNEL)
 #include <sys/param.h>
 #else
-#include <stdio.h>
+#include <roken.h>
 #endif
 #include "xdr.h"
 
diff --git a/src/rx/xdr_int64.c b/src/rx/xdr_int64.c
index bf1a571e5..c1925ed70 100644
--- a/src/rx/xdr_int64.c
+++ b/src/rx/xdr_int64.c
@@ -15,7 +15,7 @@
 #include <sys/systm.h>
 #endif
 #else
-#include <stdio.h>
+#include <roken.h>
 #endif
 #include "xdr.h"
 
diff --git a/src/rx/xdr_len.c b/src/rx/xdr_len.c
index 8e2c4cbd0..b3af0dce2 100644
--- a/src/rx/xdr_len.c
+++ b/src/rx/xdr_len.c
@@ -28,7 +28,7 @@
 #ifdef KERNEL
 # include "afs/sysincludes.h"
 #else
-# include <stdlib.h>
+# include <roken.h>
 #endif
 
 #include "xdr.h"
diff --git a/src/rx/xdr_mem.c b/src/rx/xdr_mem.c
index 0dd5daa0c..f6af534e1 100644
--- a/src/rx/xdr_mem.c
+++ b/src/rx/xdr_mem.c
@@ -43,11 +43,8 @@
 #ifdef KERNEL
 # include "afs/sysincludes.h"
 #else
-# include <string.h>
+# include <roken.h>
 # include <limits.h>
-# ifndef AFS_NT40_ENV
-#  include <netinet/in.h>
-# endif
 #endif
 
 #include "xdr.h"
diff --git a/src/rx/xdr_rec.c b/src/rx/xdr_rec.c
index abeb44d6c..6f14cb7c6 100644
--- a/src/rx/xdr_rec.c
+++ b/src/rx/xdr_rec.c
@@ -46,19 +46,8 @@
 #include <afsconfig.h>
 #include <afs/param.h>
 
-
-#include <stdio.h>
-#ifdef HAVE_STDLIB_H
-#include <stdlib.h>
-#endif
+#include <roken.h>
 #include "xdr.h"
-#ifndef AFS_NT40_ENV
-#include <sys/time.h>
-#include <netinet/in.h>
-#endif
-
-#include <string.h>
-
 
 /*  * A record is composed of one or more record fragments.
  * A record fragment is a two-byte header followed by zero to
diff --git a/src/rx/xdr_rx.c b/src/rx/xdr_rx.c
index 68da60a58..a6e8e0ccf 100644
--- a/src/rx/xdr_rx.c
+++ b/src/rx/xdr_rx.c
@@ -34,11 +34,6 @@
 # endif /* !UKERNEL */
 #else /* KERNEL */
 # include <roken.h>
-# include <sys/types.h>
-# include <stdio.h>
-# ifndef AFS_NT40_ENV
-#  include <netinet/in.h>
-# endif
 #endif /* KERNEL */
 
 #include "rx.h"
-- 
2.39.5