From a350b45814657a42708ddde3c8eace962266be70 Mon Sep 17 00:00:00 2001 From: Benjamin Kaduk Date: Sat, 2 Feb 2019 19:52:26 -0600 Subject: [PATCH] libadmin: appease clang -Wsometimes-uninitialized clang thinks that 'time' can be used uninitialized: bos.c:1472:9: error: variable 'time' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] if (as->parms[TIME].items) { ^~~~~~~~~~~~~~~~~~~~~ bos.c:1478:57: note: uninitialized use occurs here if (!bos_ExecutableRestartTimeSet(bos_server, type, time, &st)) { ^~~~ bos.c:1472:5: note: remove the 'if' if its condition is always true if (as->parms[TIME].items) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~ bos.c:1445:5: note: variable 'time' is declared here bos_RestartTime_t time; ^ but in this command description, the TIME argument is required. Add a never-triggered error exit to appease the compiler when --enable-checking is activated. Reviewed-on: https://gerrit.openafs.org/13476 Tested-by: BuildBot Reviewed-by: Cheyenne Wills Reviewed-by: Michael Meffie Reviewed-by: Benjamin Kaduk (cherry picked from commit 453060c27a5d33d3c27128d169298f9d66d06f1a) Change-Id: Iac80d4ec7c2a33dcb470de2daedf693c20b96b00 Reviewed-on: https://gerrit.openafs.org/13745 Reviewed-by: Andrew Deason Reviewed-by: Marcio Brito Barbosa Reviewed-by: Michael Meffie Tested-by: BuildBot Reviewed-by: Stephan Wiesand --- src/libadmin/test/bos.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/libadmin/test/bos.c b/src/libadmin/test/bos.c index 4da787959..92b25cba6 100644 --- a/src/libadmin/test/bos.c +++ b/src/libadmin/test/bos.c @@ -1473,6 +1473,8 @@ DoBosExecutableRestartTimeSet(struct cmd_syndesc *as, void *arock) if (ktime_ParsePeriodic(as->parms[TIME].items->data, &time) == -1) { ERR_EXT("error parsing time"); } + } else { + ERR_EXT("Mandatory time argument not supplied"); } if (!bos_ExecutableRestartTimeSet(bos_server, type, time, &st)) { -- 2.39.5