From a8160e462821d718df0bd00f1642dbc1bc9bc7a8 Mon Sep 17 00:00:00 2001 From: Simon Wilkinson Date: Wed, 23 Nov 2011 16:30:55 +0000 Subject: [PATCH] Unix CM: Fix PutVolume in afs_BlackListOnce It isn't safe to keep accessing a structure once we have Put our reference to it. Reviewed-on: http://gerrit.openafs.org/6117 Tested-by: BuildBot Reviewed-by: Jeffrey Altman (cherry picked from commit 2373547a86c12f72261072971b8d47e6b7cdd4e6) Change-Id: I013b5d6ecf7705745ab16c8736f32ca7750b933b Reviewed-on: http://gerrit.openafs.org/6124 Tested-by: BuildBot Reviewed-by: Derrick Brashear --- src/afs/afs_analyze.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/afs/afs_analyze.c b/src/afs/afs_analyze.c index 1a6c16772..a5333a196 100644 --- a/src/afs/afs_analyze.c +++ b/src/afs/afs_analyze.c @@ -259,13 +259,13 @@ afs_BlackListOnce(struct vrequest *areq, struct VenusFid *afid, areq->skipserver[i] = 1; } } - afs_PutVolume(tvp, READ_LOCK); for (i = 0; i < AFS_MAXHOSTS; i++) { if (tvp->serverHost[i] && areq->skipserver[i] == 0) { serversleft = 1; break; } } + afs_PutVolume(tvp, READ_LOCK); return serversleft; } } -- 2.39.5