From b39833048124030bc15526d116b504fd43e100bb Mon Sep 17 00:00:00 2001 From: Andrew Deason Date: Thu, 30 Jan 2014 14:43:57 -0600 Subject: [PATCH] afs: Pay attention to fetchOps->destroy error code The ->destroy function in our fetchops could change our error code, or even raise a new error. Don't ignore it. This currently doesn't do much, since fetchDestroy currently won't change the error code if it's given an error, but this can change in the future. Change-Id: I6fa98cc709cb0fbd4c1e868ba4b9be53313573ff Reviewed-on: http://gerrit.openafs.org/10787 Tested-by: BuildBot Reviewed-by: Derrick Brashear --- src/afs/afs_fetchstore.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/afs/afs_fetchstore.c b/src/afs/afs_fetchstore.c index 8db669771..a9f47a0c8 100644 --- a/src/afs/afs_fetchstore.c +++ b/src/afs/afs_fetchstore.c @@ -1169,7 +1169,7 @@ afs_CacheFetchProc(struct afs_conn *tc, struct rx_connection *rxconn, if (!code) code = (*ops->close)(rock, avc, adc, tsmall); if (ops) - (*ops->destroy)(&rock, code); + code = (*ops->destroy)(&rock, code); #ifndef AFS_NOSTATS FillStoreStats(code, AFS_STATS_FS_XFERIDX_FETCHDATA, xferStartTime, -- 2.39.5