From b5f0df472f9a39492de2cfb3855362a89ad4603b Mon Sep 17 00:00:00 2001 From: Andrew Deason Date: Wed, 8 Dec 2010 14:57:13 -0600 Subject: [PATCH] DAFS: Avoid logging harmless LEAVE_OFF failures The DAFS volserver can create temporary destroyMe volumes, which it then tells the fileserver to keep offline with an FSYNC_VOL_LEAVE_OFF message. When the fileserver doesn't know that the volume exists, currently it responds with SYNC_DENIED, which causes the volserver to log the error with a "negative response on circuit FSSYNC" message. These are harmless, though, since leaving a volume offline that the fileserver does not know about is a no-op. So return the SYNC_FAILED code instead, which does not get logged, and is more consistent with some other FSYNC handlers like FSYNC_VOL_DONE. Reviewed-on: http://gerrit.openafs.org/3494 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear (cherry picked from commit f88c91f7778b9a8bf920dce08ccab76ac0b1b433) Change-Id: Ib3956cf1035b8d9dbcc985877304837a52f9d760 Reviewed-on: http://gerrit.openafs.org/3799 Tested-by: BuildBot Reviewed-by: Derrick Brashear --- src/vol/fssync-server.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vol/fssync-server.c b/src/vol/fssync-server.c index a0c408f38..78d3bee10 100644 --- a/src/vol/fssync-server.c +++ b/src/vol/fssync-server.c @@ -734,7 +734,7 @@ FSYNC_com_VolOn(FSSYNC_VolOp_command * vcom, SYNC_response * res) res->hdr.reason = FSYNC_WRONG_PART; } } else { - code = SYNC_DENIED; + code = SYNC_FAILED; res->hdr.reason = FSYNC_UNKNOWN_VOLID; } #endif -- 2.39.5