From bdb61cc567939386c3685f15ef2ac47bcff8f9ae Mon Sep 17 00:00:00 2001 From: Simon Wilkinson Date: Fri, 30 Mar 2012 19:30:18 +0100 Subject: [PATCH] vol: Remove unneeded braces Doing if ((a==b)) is unecessary. It's also potentially dangerous, as that's the syntax required to do assignment within an if statement. clang now issues warnings (errors in -Werror mode) when it encounters these. Remove pointless braces from vol to make clang happy. Reviewed-on: http://gerrit.openafs.org/7082 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear (cherry picked from commit 58be19d792e6b8e93fbd49bc4ef04bbb8f4560ef) Change-Id: Ie2fd97927eace8a9317598c1b44d2c2610cdc31a Reviewed-on: http://gerrit.openafs.org/10739 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand --- src/vol/volume.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vol/volume.c b/src/vol/volume.c index b76344a1d..f88c6fbbd 100644 --- a/src/vol/volume.c +++ b/src/vol/volume.c @@ -8342,7 +8342,7 @@ VLookupVolume_r(Error * ec, VolId volumeId, Volume * hint) /* search the chain for this volume id */ for(queue_Scan(head, vp, np, Volume)) { looks++; - if ((vp->hashid == volumeId)) { + if (vp->hashid == volumeId) { break; } } -- 2.39.5