From be8d8b7c78eb54f460489084650ba13f3946d7a2 Mon Sep 17 00:00:00 2001 From: Simon Wilkinson Date: Sat, 31 Mar 2012 14:59:47 -0400 Subject: [PATCH] auth: Don't leak key on file parse error If we fail for any reason whilst parsing the keyfile from disk, don't leak the key structure which we allocated to store the results of the parse. Change-Id: I21a27723f96af9428465134cfb975c83e10da535 Reviewed-on: http://gerrit.openafs.org/7102 Tested-by: BuildBot Reviewed-by: Derrick Brashear --- src/auth/keys.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/auth/keys.c b/src/auth/keys.c index 52d1265c7..ba6843da1 100644 --- a/src/auth/keys.c +++ b/src/auth/keys.c @@ -458,7 +458,7 @@ _parseExtendedKeyFile(struct afsconf_dir *dir, char *fileName) { int fd, i, code; afs_int32 nkeys; - struct afsconf_typedKey *key; + struct afsconf_typedKey *key = NULL; fd = open(fileName, O_RDONLY); if (fd < 0) @@ -530,6 +530,9 @@ _parseExtendedKeyFile(struct afsconf_dir *dir, char *fileName) return 0; fail: + if (key) + afsconf_typedKey_put(&key); + close(fd); return EIO; } -- 2.39.5