From bf8746dc43567a0a8f1d4075402eb9d2f741ec04 Mon Sep 17 00:00:00 2001 From: Ben Kaduk Date: Sat, 3 Jul 2010 22:58:39 -0400 Subject: [PATCH] Do not recurse on the glock in rxk_NewSocketHost If sobind() failed, we would lock the glock before going to bad, which proceeded to lock the glock, panic()ing on the recursion attempt. Remove the unneeded first call. Change-Id: Ifa793735ebe64bde98156caa610c06612bdb92bd Reviewed-on: http://gerrit.openafs.org/2330 Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman --- src/rx/rx_kcommon.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/rx/rx_kcommon.c b/src/rx/rx_kcommon.c index d88ee40cf..17da066de 100644 --- a/src/rx/rx_kcommon.c +++ b/src/rx/rx_kcommon.c @@ -951,7 +951,6 @@ rxk_NewSocketHost(afs_uint32 ahost, short aport) if (code) { dpf(("sobind fails (%d)\n", (int)code)); soclose(newSocket); - AFS_GLOCK(); goto bad; } #else /* defined(AFS_DARWIN_ENV) || defined(AFS_FBSD_ENV) */ -- 2.39.5