From cb7a5ce44470112d3ba5e341322bb9e7d029e101 Mon Sep 17 00:00:00 2001 From: Simon Wilkinson Date: Sat, 6 Nov 2010 15:18:14 -0400 Subject: [PATCH] RX: rxi_PrepareSendPacket drops call lock; WaitforTQ required Since rxi_PrepareSendPacket drops the call->lock during processing the caller must perform a rxi_WaitforTQ prior to manipulating the transmit queue. Change-Id: Icd16444d84235c1fb647bf96bd85706c7396a4bb Reviewed-on: http://gerrit.openafs.org/3279 Tested-by: BuildBot Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear --- src/rx/rx_rdwr.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/src/rx/rx_rdwr.c b/src/rx/rx_rdwr.c index dcc9fe18c..3e05e145f 100644 --- a/src/rx/rx_rdwr.c +++ b/src/rx/rx_rdwr.c @@ -713,9 +713,6 @@ rxi_WriteProc(struct rx_call *call, char *buf, do { if (call->nFree == 0) { MUTEX_ENTER(&call->lock); -#ifdef AFS_GLOBAL_RXLOCK_KERNEL - rxi_WaitforTQBusy(call); -#endif /* AFS_GLOBAL_RXLOCK_KERNEL */ cp = call->currentPacket; if (call->error) call->mode = RX_MODE_ERROR; @@ -736,6 +733,10 @@ rxi_WriteProc(struct rx_call *call, char *buf, * conn->securityMaxTrailerSize */ hadd32(call->bytesSent, cp->length); rxi_PrepareSendPacket(call, cp, 0); +#ifdef AFS_GLOBAL_RXLOCK_KERNEL + /* PrepareSendPacket drops the call lock */ + rxi_WaitforTQBusy(call); +#endif /* AFS_GLOBAL_RXLOCK_KERNEL */ #ifdef RX_TRACK_PACKETS cp->flags |= RX_PKTFLAG_TQ; #endif @@ -1162,6 +1163,10 @@ rxi_WritevProc(struct rx_call *call, struct iovec *iov, int nio, int nbytes) * conn->securityMaxTrailerSize */ hadd32(call->bytesSent, cp->length); rxi_PrepareSendPacket(call, cp, 0); +#ifdef AFS_GLOBAL_RXLOCK_KERNEL + /* PrepareSendPacket drops the call lock */ + rxi_WaitforTQBusy(call); +#endif /* AFS_GLOBAL_RXLOCK_KERNEL */ queue_Append(&tmpq, cp); #ifdef RXDEBUG_PACKET tmpqc++; @@ -1341,9 +1346,6 @@ rxi_FlushWrite(struct rx_call *call) #endif MUTEX_ENTER(&call->lock); -#ifdef AFS_GLOBAL_RXLOCK_KERNEL - rxi_WaitforTQBusy(call); -#endif /* AFS_GLOBAL_RXLOCK_KERNEL */ if (call->error) call->mode = RX_MODE_ERROR; @@ -1373,6 +1375,10 @@ rxi_FlushWrite(struct rx_call *call) /* The 1 specifies that this is the last packet */ hadd32(call->bytesSent, cp->length); rxi_PrepareSendPacket(call, cp, 1); +#ifdef AFS_GLOBAL_RXLOCK_KERNEL + /* PrepareSendPacket drops the call lock */ + rxi_WaitforTQBusy(call); +#endif /* AFS_GLOBAL_RXLOCK_KERNEL */ #ifdef RX_TRACK_PACKETS cp->flags |= RX_PKTFLAG_TQ; #endif -- 2.39.5