From cda7556b854a07220326a617a56edcf55769567a Mon Sep 17 00:00:00 2001 From: Jeffrey Altman Date: Wed, 7 Oct 2015 18:09:17 -0400 Subject: [PATCH] Windows: InstNetProvider do not leak key handle If we open a handle, close it. Change-Id: I1a5b2308a91f3c66791e65f76ca17ae52d34789f Reviewed-on: http://gerrit.openafs.org/12050 Reviewed-by: Benjamin Kaduk Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman --- src/WINNT/afsd/afsd_service.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/WINNT/afsd/afsd_service.c b/src/WINNT/afsd/afsd_service.c index 436188893..c736706a9 100644 --- a/src/WINNT/afsd/afsd_service.c +++ b/src/WINNT/afsd/afsd_service.c @@ -1266,7 +1266,7 @@ static DWORD InstNetProvider(const char *svcname, int bInst, const char *before) { const char *strOrder = NULL; - HKEY hkOrder; + HKEY hkOrder = NULL; LONG rv; DWORD dwSize; HANDLE hProcHeap; @@ -1299,6 +1299,8 @@ InstNetProvider(const char *svcname, int bInst, const char *before) } out: + if (hkOrder) + RegCloseKey(hkOrder); free(strOrder); return rv; } -- 2.39.5