From d04df5c0e6f9136c400dd49dea3d9aec030e5ca2 Mon Sep 17 00:00:00 2001 From: Simon Wilkinson Date: Fri, 30 Mar 2012 19:33:55 +0100 Subject: [PATCH] vlserver: unsigned values are always >0 Maxvolidbump is defined as an unisgned int, and thus can never be less than 0. Remove the pointless check, as it just makes clang sad. Reviewed-on: http://gerrit.openafs.org/7084 Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit 350b5d58779cc127b96497283c2d982e099b911c) Change-Id: Ib902a5b165219469db5f370ebea4c078f10726ee Reviewed-on: http://gerrit.openafs.org/10740 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand --- src/vlserver/vlprocs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vlserver/vlprocs.c b/src/vlserver/vlprocs.c index 22d0687db..169bbddee 100644 --- a/src/vlserver/vlprocs.c +++ b/src/vlserver/vlprocs.c @@ -593,7 +593,7 @@ SVL_GetNewVolumeId(struct rx_call *rxcall, afs_uint32 Maxvolidbump, if (!afsconf_SuperUser(vldb_confdir, rxcall, NULL)) END(VL_PERM); - if (Maxvolidbump < 0 || Maxvolidbump > MAXBUMPCOUNT) + if (Maxvolidbump > MAXBUMPCOUNT) END(VL_BADVOLIDBUMP); if ((errorcode = Init_VLdbase(&ctx, LOCKWRITE, this_op))) -- 2.39.5