From d42db13152fb8fa374db6531020da6effca51ab4 Mon Sep 17 00:00:00 2001 From: Jeffrey Altman Date: Mon, 21 Nov 2011 13:14:40 -0500 Subject: [PATCH] Windows: cm_GetSCache do not release unheld lock if cm_GetNewSCache() fails, an attempt would be made to release cm_scacheLock which is not held. However, it should be noted that cm_GetNewSCache() cannot fail without itself triggering a panic. Change-Id: I316e33712440c2bd816294ad788ad125ab7b4a73 Reviewed-on: http://gerrit.openafs.org/6103 Tested-by: BuildBot Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman --- src/WINNT/afsd/cm_scache.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/WINNT/afsd/cm_scache.c b/src/WINNT/afsd/cm_scache.c index b5666ad4c..dcbe79b5a 100644 --- a/src/WINNT/afsd/cm_scache.c +++ b/src/WINNT/afsd/cm_scache.c @@ -753,7 +753,6 @@ long cm_GetSCache(cm_fid_t *fidp, cm_scache_t **outScpp, cm_user_t *userp, scp = cm_GetNewSCache(FALSE); /* returns scp->rw held */ if (scp == NULL) { osi_Log0(afsd_logp,"cm_GetSCache unable to obtain *new* scache entry"); - lock_ReleaseWrite(&cm_scacheLock); return CM_ERROR_WOULDBLOCK; } } else { -- 2.39.5