From d58dc56d9986ab863065e5f3d8f926a25aa5b5bf Mon Sep 17 00:00:00 2001
From: Simon Wilkinson <sxw@inf.ed.ac.uk>
Date: Sat, 11 Jul 2009 18:54:15 +0100
Subject: [PATCH] Add system headers

There are a number of places in the tree which are missing system
headers such as <unistd.h> <ctype.h> and <dirent.h>. Add these.

Reviewed-on: http://gerrit.openafs.org/62
Verified-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
---
 src/afs/UKERNEL/afs_usrops.c    | 5 +++++
 src/auth/cellconfig.c           | 2 ++
 src/auth/ktc.c                  | 1 +
 src/gtx/input.c                 | 1 +
 src/libadmin/pts/afs_ptsAdmin.c | 1 +
 src/libadmin/test/vos.c         | 1 +
 src/rx/rx_pthread.c             | 1 +
 src/rx/rx_user.c                | 1 +
 src/rxkad/rxkad_client.c        | 1 +
 src/rxkad/ticket.c              | 2 +-
 src/util/hostparse.c            | 1 +
 src/viced/callback.c            | 1 +
 src/vol/clone.c                 | 1 +
 src/vol/daemon_com.c            | 1 +
 src/vol/fssync-server.c         | 1 +
 src/vol/nuke.c                  | 4 ++++
 src/vol/partition.c             | 1 +
 src/vol/purge.c                 | 1 +
 src/volser/vol_split.c          | 1 +
 src/volser/volmain.c            | 1 +
 20 files changed, 28 insertions(+), 1 deletion(-)

diff --git a/src/afs/UKERNEL/afs_usrops.c b/src/afs/UKERNEL/afs_usrops.c
index 3c7bfdcff..94f7c8984 100644
--- a/src/afs/UKERNEL/afs_usrops.c
+++ b/src/afs/UKERNEL/afs_usrops.c
@@ -21,6 +21,11 @@
 
 #include "afs/sysincludes.h"	/* Standard vendor system headers */
 #include <net/if.h>
+#include <ctype.h>
+#include <unistd.h>
+#include <sys/types.h>
+#include <dirent.h>
+
 #include "afsincludes.h"	/* Afs-based standard headers */
 #include "afs_usrops.h"
 #include "afs/afs_stats.h"
diff --git a/src/auth/cellconfig.c b/src/auth/cellconfig.c
index 9f6bef6c1..72fa3d0f0 100644
--- a/src/auth/cellconfig.c
+++ b/src/auth/cellconfig.c
@@ -19,6 +19,7 @@
 #include "des/des.h"
 #include "rx/rxkad.h"
 #include <netdb.h>
+#include <ctype.h>
 #else /* UKERNEL */
 #include <sys/types.h>
 #ifdef AFS_NT40_ENV
@@ -32,6 +33,7 @@
 #include <netdb.h>
 #include <sys/file.h>
 #include <sys/time.h>
+#include <ctype.h>
 #ifdef AFS_AFSDB_ENV
 #include <arpa/nameser.h>
 #ifdef HAVE_ARPA_NAMESER_COMPAT_H
diff --git a/src/auth/ktc.c b/src/auth/ktc.c
index 01ec23378..6d2675093 100644
--- a/src/auth/ktc.c
+++ b/src/auth/ktc.c
@@ -27,6 +27,7 @@
 #include "afs/venus.h"
 #include "afs/pthread_glock.h"
 #include "afs/dirpath.h"
+#include <ctype.h>
 
 #if !defined(min)
 #define min(a,b) ((a)<(b)?(a):(b))
diff --git a/src/gtx/input.c b/src/gtx/input.c
index 74114400d..b905073ba 100644
--- a/src/gtx/input.c
+++ b/src/gtx/input.c
@@ -10,6 +10,7 @@
 #include <afsconfig.h>
 #include <afs/param.h>
 
+#include <stdlib.h>
 
 #ifdef AFS_HPUX_ENV
 #include <sys/types.h>
diff --git a/src/libadmin/pts/afs_ptsAdmin.c b/src/libadmin/pts/afs_ptsAdmin.c
index c33b293f8..e671f95d3 100644
--- a/src/libadmin/pts/afs_ptsAdmin.c
+++ b/src/libadmin/pts/afs_ptsAdmin.c
@@ -12,6 +12,7 @@
 
 
 #include <stdio.h>
+#include <ctype.h>
 #include <afs/stds.h>
 #include <rx/rx.h>
 #include <rx/rxstat.h>
diff --git a/src/libadmin/test/vos.c b/src/libadmin/test/vos.c
index ea09921a6..0d5aa4603 100644
--- a/src/libadmin/test/vos.c
+++ b/src/libadmin/test/vos.c
@@ -18,6 +18,7 @@
 #include <netinet/in.h>
 #include <arpa/inet.h>
 #include <afs/afsutil.h>
+#include <unistd.h>
 #endif
 
 
diff --git a/src/rx/rx_pthread.c b/src/rx/rx_pthread.c
index d0cd33185..40507fbf6 100644
--- a/src/rx/rx_pthread.c
+++ b/src/rx/rx_pthread.c
@@ -31,6 +31,7 @@
 # include <net/if.h>
 # include <sys/ioctl.h>
 # include <sys/time.h>
+# include <unistd.h>
 #endif
 #include <sys/stat.h>
 #include <rx/rx.h>
diff --git a/src/rx/rx_user.c b/src/rx/rx_user.c
index 78c992bfa..8049bb679 100644
--- a/src/rx/rx_user.c
+++ b/src/rx/rx_user.c
@@ -28,6 +28,7 @@
 # include <sys/time.h>
 # include <net/if.h>
 # include <sys/ioctl.h>
+# include <unistd.h>
 #endif
 # include <fcntl.h>
 #if !defined(AFS_AIX_ENV) && !defined(AFS_NT40_ENV) 
diff --git a/src/rxkad/rxkad_client.c b/src/rxkad/rxkad_client.c
index 26ef6df3c..150efd7fb 100644
--- a/src/rxkad/rxkad_client.c
+++ b/src/rxkad/rxkad_client.c
@@ -50,6 +50,7 @@
 #include <winsock2.h>
 #else
 #include <netinet/in.h>
+#include <unistd.h>
 #endif
 #include <rx/rx.h>
 #include <rx/xdr.h>
diff --git a/src/rxkad/ticket.c b/src/rxkad/ticket.c
index 4e0864bc9..7b6392910 100644
--- a/src/rxkad/ticket.c
+++ b/src/rxkad/ticket.c
@@ -226,7 +226,7 @@ tkt_MakeTicket(char *ticket, int *ticketLen, struct ktc_encryptionKey *key,
 	return -1;
 
     /* encrypt ticket */
-    if (code = key_sched(key, schedule.schedule)) {
+    if ((code = key_sched(key, schedule.schedule))) {
 	printf("In tkt_MakeTicket: key_sched returned %d\n", code);
 	return RXKADBADKEY;
     }
diff --git a/src/util/hostparse.c b/src/util/hostparse.c
index b68d714a5..86361f693 100644
--- a/src/util/hostparse.c
+++ b/src/util/hostparse.c
@@ -19,6 +19,7 @@
 #include "afs/sysincludes.h"
 #include "afs/afsutil.h"
 #include <netdb.h>
+#include <ctype.h>
 #else /* UKERNEL */
 #include <stdio.h>
 #include <sys/types.h>
diff --git a/src/viced/callback.c b/src/viced/callback.c
index 984a6cfc4..7860e4904 100644
--- a/src/viced/callback.c
+++ b/src/viced/callback.c
@@ -95,6 +95,7 @@
 #else
 #include <sys/time.h>
 #include <sys/file.h>
+#include <unistd.h>
 #endif
 #include <afs/assert.h>
 
diff --git a/src/vol/clone.c b/src/vol/clone.c
index b848a7753..ea32812d4 100644
--- a/src/vol/clone.c
+++ b/src/vol/clone.c
@@ -35,6 +35,7 @@
 #else
 #include <sys/file.h>
 #include <sys/time.h>
+#include <unistd.h>
 #endif
 #include <string.h>
 #include <errno.h>
diff --git a/src/vol/daemon_com.c b/src/vol/daemon_com.c
index 28bcf520c..5c3d801de 100644
--- a/src/vol/daemon_com.c
+++ b/src/vol/daemon_com.c
@@ -33,6 +33,7 @@
 #include <netinet/in.h>
 #include <netdb.h>
 #include <sys/time.h>
+#include <unistd.h>
 #endif
 #include <errno.h>
 #include <assert.h>
diff --git a/src/vol/fssync-server.c b/src/vol/fssync-server.c
index ef604201a..d59605622 100644
--- a/src/vol/fssync-server.c
+++ b/src/vol/fssync-server.c
@@ -55,6 +55,7 @@
 #include <netinet/in.h>
 #include <netdb.h>
 #include <sys/time.h>
+#include <unistd.h>
 #endif
 #include <errno.h>
 #ifdef AFS_PTHREAD_ENV
diff --git a/src/vol/nuke.c b/src/vol/nuke.c
index fb6df1b86..f1de4d1ee 100644
--- a/src/vol/nuke.c
+++ b/src/vol/nuke.c
@@ -27,6 +27,10 @@
 #else
 #include <strings.h>
 #endif
+#ifndef AFS_NT40_ENV
+#include <unistd.h>
+#endif
+
 #include <afs/afsutil.h>
     
 #include <afs/assert.h>
diff --git a/src/vol/partition.c b/src/vol/partition.c
index 7a1087420..8542410a1 100644
--- a/src/vol/partition.c
+++ b/src/vol/partition.c
@@ -31,6 +31,7 @@
 #else
 #include <sys/param.h>
 #include <sys/types.h>
+#include <unistd.h>
 
 #if AFS_HAVE_STATVFS || AFS_HAVE_STATVFS64
 #include <sys/statvfs.h>
diff --git a/src/vol/purge.c b/src/vol/purge.c
index 15b871b72..3248e463c 100644
--- a/src/vol/purge.c
+++ b/src/vol/purge.c
@@ -25,6 +25,7 @@
 #include <sys/param.h>
 #include <sys/file.h>
 #include <sys/time.h>
+#include <unistd.h>
 #endif
 #include <string.h>
 #include <sys/stat.h>
diff --git a/src/volser/vol_split.c b/src/volser/vol_split.c
index f541041fe..8af67eafc 100644
--- a/src/volser/vol_split.c
+++ b/src/volser/vol_split.c
@@ -25,6 +25,7 @@
 #else
 #include <sys/file.h>
 #include <sys/time.h>
+#include <unistd.h>
 #endif
 #ifdef HAVE_STRING_H
 #include <string.h>
diff --git a/src/volser/volmain.c b/src/volser/volmain.c
index 8f40a6df5..b78085ed9 100644
--- a/src/volser/volmain.c
+++ b/src/volser/volmain.c
@@ -22,6 +22,7 @@
 #include <sys/time.h>
 #include <sys/file.h>
 #include <netinet/in.h>
+#include <unistd.h>
 #endif
 #include <rx/xdr.h>
 #include <afs/afsint.h>
-- 
2.39.5