From d5a6a895e3b004666b0d6aaa9fe4313b0a831dbd Mon Sep 17 00:00:00 2001 From: Jeffrey Altman Date: Mon, 17 Oct 2011 09:28:11 -0400 Subject: [PATCH] Windows: free pointer after last reference This is a superficial change but is being done for readability. If given the choice of freeing memory and then testing the pointer value or vice-versa, test the pointer value first. Change-Id: I189851c265a257d433df111622837db1d706c054 Reviewed-on: http://gerrit.openafs.org/5626 Reviewed-by: Jeffrey Altman Reviewed-by: Rod Widdowson Tested-by: Jeffrey Altman --- src/WINNT/afsrdr/kernel/lib/AFSGeneric.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/WINNT/afsrdr/kernel/lib/AFSGeneric.cpp b/src/WINNT/afsrdr/kernel/lib/AFSGeneric.cpp index 831cf2475..d03c63dca 100644 --- a/src/WINNT/afsrdr/kernel/lib/AFSGeneric.cpp +++ b/src/WINNT/afsrdr/kernel/lib/AFSGeneric.cpp @@ -5962,14 +5962,14 @@ try_exit: // offset by the length of the server name // - AFSExFreePool( pwchBuffer); - if( uniFullPathName.Length > 0 && pwchBuffer != (WCHAR *)((char *)uniFullPathName.Buffer - ulNameDifference)) { AFSExFreePool( uniFullPathName.Buffer); } + + AFSExFreePool( pwchBuffer); } } @@ -6482,14 +6482,14 @@ try_exit: // offset by the length of the server name // - AFSExFreePool( pwchBuffer); - if( uniFullPathName.Length > 0 && pwchBuffer != (WCHAR *)((char *)uniFullPathName.Buffer - ulNameDifference)) { AFSExFreePool( uniFullPathName.Buffer); } + + AFSExFreePool( pwchBuffer); } } -- 2.39.5