From d93b89ddb61d44b47f039ae96af6304f2d87b5e2 Mon Sep 17 00:00:00 2001 From: Jeffrey Altman Date: Tue, 21 Jan 2014 04:19:28 -0500 Subject: [PATCH] Windows: AFSEvaluateTargetByName NULL ptr assignment If DirEnumEntry is NULL, then on failure of AFSEvaluateTargetByName() a NULL pointer will be dereferenced prior to function return. Change-Id: I6d0d646e667c4b805abcddce1af49b81037ae51d Reviewed-on: http://gerrit.openafs.org/11422 Tested-by: BuildBot Reviewed-by: Jeffrey Altman --- src/WINNT/afsrdr/kernel/lib/AFSCommSupport.cpp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/WINNT/afsrdr/kernel/lib/AFSCommSupport.cpp b/src/WINNT/afsrdr/kernel/lib/AFSCommSupport.cpp index 858aba0c8..f912cea58 100644 --- a/src/WINNT/afsrdr/kernel/lib/AFSCommSupport.cpp +++ b/src/WINNT/afsrdr/kernel/lib/AFSCommSupport.cpp @@ -3024,7 +3024,11 @@ try_exit: AFSExFreePoolWithTag( pDirEnumCB, AFS_GENERIC_MEMORY_3_TAG); } - *DirEnumEntry = NULL; + if( DirEnumEntry != NULL) + { + + *DirEnumEntry = NULL; + } } } -- 2.39.5