From d9cc9c9dee9ad0213ddd39174e81d01b9707937b Mon Sep 17 00:00:00 2001 From: Nickolai Zeldovich Date: Sat, 5 Jan 2013 23:45:11 -0500 Subject: [PATCH] tools/dumpscan/pathname.c: properly check strdup() return value Fix the check for strdup() running out of memory. Change-Id: I4e2d83036095c7b292ee4c386d8ed7b16ec75067 Reviewed-on: http://gerrit.openafs.org/8880 Reviewed-by: Derrick Brashear Reviewed-by: Jeffrey Altman Tested-by: BuildBot --- src/tools/dumpscan/pathname.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tools/dumpscan/pathname.c b/src/tools/dumpscan/pathname.c index db2458870..b4d4e5cf3 100644 --- a/src/tools/dumpscan/pathname.c +++ b/src/tools/dumpscan/pathname.c @@ -278,7 +278,7 @@ Path_Build(XFILE * X, path_hashinfo * phi, afs_uint32 vnode, char **his_path, if (vnode == 1) { *his_path = strdup("/"); - if (!his_path) { + if (!*his_path) { if (phi->p->cb_error) (phi->p->cb_error) (ENOMEM, 1, phi->p->err_refcon, "No memory for pathname of vnode 1"); -- 2.39.5