From de868eea27dcb09d8821b331110d807f862d1c91 Mon Sep 17 00:00:00 2001 From: Derrick Brashear Date: Fri, 17 Jan 2003 06:47:35 +0000 Subject: [PATCH] STABLE12-vol-clone-inc-failure-logging-20030117 log more info on asserts (cherry picked from commit ec111ccc442439f68e9052721571ec8ef1754644) --- src/vol/clone.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/src/vol/clone.c b/src/vol/clone.c index 1294a1a9a..34bb3328d 100644 --- a/src/vol/clone.c +++ b/src/vol/clone.c @@ -230,8 +230,13 @@ afs_int32 DoCloneIndex(rwvp, clvp, class, reclone) if (clinode && (clinode == rwinode)) { clinode = 0; /* already cloned - don't delete later */ } else if (rwinode) { - assert(IH_INC(V_linkHandle(rwvp), rwinode, V_parentId(rwvp)) != -1); - inodeinced = 1; + if (IH_INC(V_linkHandle(rwvp), rwinode, V_parentId(rwvp)) == -1) { + Log("IH_INC failed: %x, %s, %d errno %d\n", + V_linkHandle(rwvp), PrintInode(NULL, rwinode), + V_parentId(rwvp), errno); + assert(0); + } + inodeinced = 1; } /* If a directory, mark vnode in old volume as cloned */ @@ -273,7 +278,12 @@ afs_int32 DoCloneIndex(rwvp, clvp, class, reclone) clonefailed: /* Couldn't clone, go back and decrement the inode's link count */ if (inodeinced) { - assert(IH_DEC(V_linkHandle(rwvp), rwinode, V_parentId(rwvp)) != -1); + if (IH_DEC(V_linkHandle(rwvp), rwinode, V_parentId(rwvp)) == -1) { + Log("IH_DEC failed: %x, %s, %d errno %d\n", + V_linkHandle(rwvp), PrintInode(NULL, rwinode), + V_parentId(rwvp), errno); + assert(0); + } } /* And if the directory was marked clone, unmark it */ if (dircloned) { -- 2.39.5