From e2e415e9846ee45297af53f659e43d06e49ee6ea Mon Sep 17 00:00:00 2001 From: Simon Wilkinson Date: Tue, 19 Feb 2013 14:41:26 +0000 Subject: [PATCH] vos: Remove unused 'done' loop variable In SendFile we break at the same time as setting the done flag, so its value is never checked. Just remove it as it is redundant with the current loop logic. Caught by clang-analyzer Change-Id: Ibf8f756b06fd26cb2013ece97eb9196c71ad88bd Reviewed-on: http://gerrit.openafs.org/9164 Tested-by: BuildBot Reviewed-by: Chas Williams - CONTRACTOR Reviewed-by: Derrick Brashear --- src/volser/vos.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/volser/vos.c b/src/volser/vos.c index cb807a0f3..429fbce6f 100644 --- a/src/volser/vos.c +++ b/src/volser/vos.c @@ -280,7 +280,6 @@ SendFile(usd_handle_t ufd, struct rx_call *call, long blksize) { char *buffer = (char *)0; afs_int32 error = 0; - int done = 0; afs_uint32 nbytes; buffer = malloc(blksize); @@ -289,7 +288,7 @@ SendFile(usd_handle_t ufd, struct rx_call *call, long blksize) return -1; } - while (!error && !done) { + while (!error) { #ifndef AFS_NT40_ENV /* NT csn't select on non-socket fd's */ fd_set in; FD_ZERO(&in); @@ -307,10 +306,10 @@ SendFile(usd_handle_t ufd, struct rx_call *call, long blksize) afs_error_message(error)); break; } - if (nbytes == 0) { - done = 1; + + if (nbytes == 0) break; - } + if (rx_Write(call, buffer, nbytes) != nbytes) { error = -1; break; -- 2.39.5