From e511a4069e30ecf14375f58380972b17b04e0fc2 Mon Sep 17 00:00:00 2001 From: Simon Wilkinson Date: Sat, 2 Mar 2013 09:33:12 +0000 Subject: [PATCH] kauth: Don't overflow cell string The cell string within a ktc_principal is only 64 characters long. Be careful not to overflow it. Caught by coverity (#985829) Reviewed-on: http://gerrit.openafs.org/9350 Tested-by: BuildBot Reviewed-by: Jeffrey Altman (cherry picked from commit 77aa6c65b74e46c77dfaf440745496ab98b14244) Change-Id: I7e0411ce635d481cf1618c2eabf79dfb85fcd069 Reviewed-on: http://gerrit.openafs.org/11037 Reviewed-by: Andrew Deason Tested-by: BuildBot Reviewed-by: Chas Williams - CONTRACTOR Reviewed-by: Stephan Wiesand --- src/kauth/knfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/kauth/knfs.c b/src/kauth/knfs.c index 6852e44a7..08b0ef931 100644 --- a/src/kauth/knfs.c +++ b/src/kauth/knfs.c @@ -190,7 +190,7 @@ GetTokens(afs_int32 ahost, afs_int32 auid) sprintf(clientName.name, "Unix UID %d", ct.ViceId); clientName.instance[0] = 0; } - strcpy(clientName.cell, tp); + strlcpy(clientName.cell, tp, sizeof(clientName.cell)); tokenExpireTime = token.endTime; strcpy(UserName, clientName.name); -- 2.39.5