From e7035b876f6c3e1bcf1053910f6ae74115f7b039 Mon Sep 17 00:00:00 2001 From: Simon Wilkinson Date: Tue, 19 Feb 2013 15:15:42 +0000 Subject: [PATCH] kauth: Fix some unnecessary variable assignments Remove various places where a variable is assigned to, and then the result never read. Caught by clang-analyzer Change-Id: Id8b7aeb6c54b7c93093ad44df5a9fe01575f2fbe Reviewed-on: http://gerrit.openafs.org/9172 Reviewed-by: Derrick Brashear Tested-by: BuildBot Reviewed-by: Jeffrey Altman --- src/kauth/admin_tools.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/kauth/admin_tools.c b/src/kauth/admin_tools.c index f518eb2d8..b7899a1b8 100644 --- a/src/kauth/admin_tools.c +++ b/src/kauth/admin_tools.c @@ -875,7 +875,6 @@ PrintName(char *name, char *inst, char *acell, int buflen, char *buf) left = ka_ConvertBytes(buf + nlen, buflen - nlen, acell, len); if (left) goto bad_name; - nlen += len; } } return 0; @@ -1318,7 +1317,7 @@ MyBeforeProc(struct cmd_syndesc *as, void *arock) /* MyAfterProc() destroys the conn, but just to be sure */ if (conn) { - code = ubik_ClientDestroy(conn); + ubik_ClientDestroy(conn); conn = 0; } @@ -1670,8 +1669,8 @@ ka_AdminInteractive(int cmd_argc, char *cmd_argv[]) "enter interactive mode"); add_std_args(ts); - ts = cmd_CreateSyntax("noauthentication", NoAuth, NULL, - "connect to AuthServer w/o using token"); + cmd_CreateSyntax("noauthentication", NoAuth, NULL, + "connect to AuthServer w/o using token"); ts = cmd_CreateSyntax("list", ListUsers, NULL, "list all users in database"); @@ -1805,7 +1804,7 @@ ka_AdminInteractive(int cmd_argc, char *cmd_argv[]) cmd_AddParm(ts, "-long", CMD_FLAG, CMD_OPTIONAL, "show session key and ticket"); - ts = cmd_CreateSyntax("quit", Quit, NULL, "exit program"); + cmd_CreateSyntax("quit", Quit, NULL, "exit program"); finished = 1; conn = 0; /* no connection yet */ -- 2.39.5