From f14f8d45bcf3181f08971e6ed8d54bff48bbafe6 Mon Sep 17 00:00:00 2001
From: Andrew Deason <adeason@sinenomine.net>
Date: Fri, 15 Oct 2010 16:37:55 -0500
Subject: [PATCH] pts: Prevent creating negative user ids

User ids cannot be negative (those are groups). So, error out if a
negative id is specified for createuser.

FIXES 128343

Reviewed-on: http://gerrit.openafs.org/2993
Tested-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Phillip Moore <w.phillip.moore@gmail.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Tested-by: Jeffrey Altman <jaltman@openafs.org>
(cherry picked from commit ebfc586fd2d00085a384763cc519c2af6ce5223e)
Change-Id: I6a107dc5a1a6d98823f5377657856ca41566cb2b
Reviewed-on: http://gerrit.openafs.org/3108
Tested-by: Derrick Brashear <shadow@dementia.org>
---
 src/ptserver/pts.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/ptserver/pts.c b/src/ptserver/pts.c
index 3a74c5eae..17a99442c 100644
--- a/src/ptserver/pts.c
+++ b/src/ptserver/pts.c
@@ -340,6 +340,12 @@ CreateUser(struct cmd_syndesc *as, void *arock)
 		printf("0 isn't a valid user id; aborting\n");
 		return EINVAL;
 	    }
+	    if (id < 0) {
+		code = PRBADARG;
+		afs_com_err(whoami, code, "because user id %d was not positive",
+			id);
+		return code;
+	    }
 	    idi = idi->next;
 	} else
 	    id = 0;
-- 
2.39.5